git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/4] run-command.c: print env vars when GIT_TRACE is set

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jan 12, 2018, 09:56 UTC
Message-ID
<20180112095607.18293-1-pclouds@gmail.com>
In-Reply-To
<20180111094712.2551-1-pclouds@gmail.com>
v3 turns a single patch into a series. Changes from v2
- env var quoting is now done correctly (from shell syntax perspective)
- the program name is prepended in git_cmd mode
- cwd is now printed too (because I have too, see 4/4)
- we don't blindly print the env delta anymore but print the actual
  differences compared to parent env
- which means we also print "unset XXX" statements in $GIT_TRACE
The new output on git.git looks like this
    trace: run_command: cd 'sha1collisiondetection'; unset GIT_PREFIX; GIT_DIR='.git' git 'status' '--porcelain=2'

a bit longer than I would like, but that's because of sha1collisiondetection and it's not long enough for me to invent $GIT_TRACE_EXEC.

I'm not adding "sh -c" back though because that looks like it should be done in run_command.c itself, not just output tracing output.

Oh.. before anybody asks, I'm not adding git prefix to the "cd" part. You're supposed to know that git moves back to worktree top dir when you read $GIT_TRACE (or are welcome to improve the print out).

Nguyễn Thái Ngọc Duy (4):
  trace.c: introduce trace_run_command()
  trace.c: print program 'git' when child_process.git_cmd is set
  trace.c: print env vars in trace_run_command()
  trace.c: be smart about what env to print in trace_run_command()
 run-command.c |   3 +-
 trace.c       | 106 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 trace.h       |   3 ++
 3 files changed, 111 insertions(+), 1 deletion(-)
-- 
2.15.1.600.g899a5f85c6
Previous: Duy NguyenNext: Nguyễn Thái Ngọc Duy
Message 12 of 74 in “run-command.c: print env vars when GIT_TRACE is set”
  1. run-command.c: print env vars when GIT_TRACE is setNguyễn Thái Ngọc Duy, Jan 10, 2018
  2. Brandon WilliamsJan 10, 2018
  3. Stefan BellerJan 10, 2018
  4. Brandon WilliamsJan 10, 2018
  5. Stefan BellerJan 10, 2018
  6. run-command.c: print env vars when GIT_TRACE is setNguyễn Thái Ngọc Duy, Jan 11, 2018
  7. Duy NguyenJan 11, 2018
  8. Brandon WilliamsJan 11, 2018
  9. Stefan BellerJan 11, 2018
  10. Junio C HamanoJan 11, 2018
  11. Duy NguyenJan 12, 2018
  12. 0/4 run-command.c: print env vars when GIT_TRACE is setNguyễn Thái Ngọc Duy, Jan 12, 2018
  13. 1/4 trace.c: introduce trace_run_command()Nguyễn Thái Ngọc Duy, Jan 12, 2018
  14. Jeff KingJan 12, 2018
  15. Jeff KingJan 12, 2018
  16. 2/4 trace.c: print program 'git' when child_process.git_cmd is setNguyễn Thái Ngọc Duy, Jan 12, 2018
  17. Jeff KingJan 12, 2018
  18. 3/4 trace.c: print env vars in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 12, 2018
  19. Jeff KingJan 12, 2018
  20. 4/4 trace.c: be smart about what env to print in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 12, 2018
  21. Jeff KingJan 12, 2018
  22. Junio C HamanoJan 12, 2018
  23. Jeff KingJan 12, 2018
  24. Junio C HamanoJan 12, 2018
  25. Jeff KingJan 12, 2018
  26. Brandon WilliamsJan 12, 2018
  27. Junio C HamanoJan 12, 2018
  28. Duy NguyenJan 13, 2018
  29. Duy NguyenJan 13, 2018
  30. Jeff KingJan 12, 2018
  31. 5/4 sq_quote_argv: drop maxlen parameterJeff King, Jan 12, 2018
  32. Junio C HamanoJan 12, 2018
  33. 6/4 trace: avoid unnecessary quotingJeff King, Jan 12, 2018
  34. Stefan BellerJan 12, 2018
  35. Stefan BellerJan 12, 2018
  36. Duy NguyenJan 13, 2018
  37. 0/7 Trace env variables in run_command()Nguyễn Thái Ngọc Duy, Jan 13, 2018
  38. 1/7 sq_quote_argv: drop maxlen parameterNguyễn Thái Ngọc Duy, Jan 13, 2018
  39. 2/7 trace: avoid unnecessary quotingNguyễn Thái Ngọc Duy, Jan 13, 2018
  40. 3/7 trace.c: move strbuf_release() out of print_trace_line()Nguyễn Thái Ngọc Duy, Jan 13, 2018
  41. Jeff KingJan 13, 2018
  42. 4/7 trace.c: introduce trace_run_command()Nguyễn Thái Ngọc Duy, Jan 13, 2018
  43. 5/7 trace.c: print program 'git' when child_process.git_cmd is setNguyễn Thái Ngọc Duy, Jan 13, 2018
  44. 6/7 trace.c: print env vars in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 13, 2018
  45. Jeff KingJan 13, 2018
  46. Junio C HamanoJan 16, 2018
  47. Stefan BellerJan 16, 2018
  48. Junio C HamanoJan 17, 2018
  49. 7/7 trace.c: print new cwd in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 13, 2018
  50. Jeff KingJan 13, 2018
  51. 0/7 Trace env variables in run_command()Nguyễn Thái Ngọc Duy, Jan 15, 2018
  52. 1/7 sq_quote_argv: drop maxlen parameterNguyễn Thái Ngọc Duy, Jan 15, 2018
  53. 2/7 trace: avoid unnecessary quotingNguyễn Thái Ngọc Duy, Jan 15, 2018
  54. 3/7 trace.c: move strbuf_release() out of print_trace_line()Nguyễn Thái Ngọc Duy, Jan 15, 2018
  55. Brandon WilliamsJan 16, 2018
  56. 4/7 trace.c: introduce trace_run_command()Nguyễn Thái Ngọc Duy, Jan 15, 2018
  57. Jeff KingJan 17, 2018
  58. Junio C HamanoJan 17, 2018
  59. 5/7 trace.c: print program 'git' when child_process.git_cmd is setNguyễn Thái Ngọc Duy, Jan 15, 2018
  60. 6/7 trace.c: print env vars in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 15, 2018
  61. Brandon WilliamsJan 16, 2018
  62. 7/7 trace.c: print new cwd in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 15, 2018
  63. 0/7 Trace env variables in run_command()Nguyễn Thái Ngọc Duy, Jan 18, 2018
  64. 1/7 sq_quote_argv: drop maxlen parameterNguyễn Thái Ngọc Duy, Jan 18, 2018
  65. 2/7 trace: avoid unnecessary quotingNguyễn Thái Ngọc Duy, Jan 18, 2018
  66. 3/7 trace.c: move strbuf_release() out of print_trace_line()Nguyễn Thái Ngọc Duy, Jan 18, 2018
  67. 4/7 run-command.c: introduce trace_run_command()Nguyễn Thái Ngọc Duy, Jan 18, 2018
  68. 5/7 run-command.c: print program 'git' when tracing git_cmd modeNguyễn Thái Ngọc Duy, Jan 18, 2018
  69. 6/7 run-command.c: print env vars in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 18, 2018
  70. 7/7 run-command.c: print new cwd in trace_run_command()Nguyễn Thái Ngọc Duy, Jan 18, 2018
  71. Jeff KingJan 19, 2018
  72. Jeff KingJan 11, 2018
  73. Duy NguyenJan 11, 2018
  74. Johannes SixtJan 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.