Re: [PATCH v4 6/7] t/Makefile: run unit tests alongside shell tests
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
>> if test -z "${TEST_SHELL_PATH:+set}"
>> then
>> echo >&2 "ERROR: TEST_SHELL_PATH is not set or empty"
>>
>> may be what we want here.
>
> If we are using ":+" to handle the empty string, I think just:
>
> if test -z "$TEST_SHELL_PATH"
>
> is sufficient, no?Yes. And the other part of this hunk still needs fixing, namely,
> + exit 1
> + fi
> + exec ${TEST_SHELL_PATH} "$@"
> + ;;the above reference needs to be quoted protect $IFS in the path.
Junio C Hamano <gitster@pobox.com>