Re: [PATCH v3 0/7] test-tool: add unit test suite runner
- From
Jeff King <peff@peff.net>
- Date
- Mar 27, 2024, 09:00 UTC
- Message-ID
- <20240327090000.GB846805@coredump.intra.peff.net>
- In-Reply-To
- <xmqqjzlo8yqr.fsf@gitster.g>
On Tue, Mar 26, 2024 at 02:33:16PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> Josh Steadmon <steadmon@google.com> writes: > > > Please note: this series has once again been rebased onto the latest > > jk/unit-tests-buildfix. > > > > For various reasons (see discussion at [1]) we would like an alternative > > to `prove` for running test suites (including the unit tests) on > > Windows. > > Folks, what's the status of this one? I just checked the RFC thread > and this last one (more than a month ago) and the issues seems to > have been addressed, but I prefer positive acks rather than "we've > seen it already, take our silence as the sign of endorsement".
It is not a topic I am really interested in, so I was not following closely. But I think my earlier issues were addressed, and from a quick read now it looks OK to me. (I left one small comment, but I don't think it's a big deal either way).
-Peff