git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH v2 4/6] test-tool run-command testsuite: support unit tests

From
Josh Steadmon <steadmon@google.com>
Date
Feb 23, 2024, 22:45 UTC
Message-ID
<ZdkgJMu3bddMmdbd@google.com>
In-Reply-To
<xmqqbk8s80hh.fsf@gitster.g>
On 2024.02.07 12:48, Junio C Hamano wrote:
Show 19 quoted lines
> Josh Steadmon <steadmon@google.com> writes:
> 
> > Teach the testsuite runner in `test-tool run-command testsuite` how to
> > run unit tests: if TEST_SHELL_PATH is not set, assume that we're running
> > the programs directly from CWD, rather than defaulting to "sh" as an
> > interpreter.
> 
> Hmph.  It sounds more like "the run-command testsuite subcommand
> only runs programs in the current directory", not "assume" (which
> implies there is a way to override the assumption).  Not that the
> limitation would hurt us in any way, though.
> 
> > +	/*
> > +	 * If we run without a shell, we have to provide the relative path to
> > +	 * the executables.
> > +	 */
> 
> It sounds more like "If TEST_SHELL_PATH is not given, then we run
> them in the current directory.".
Reworded both of these in V3.
Previous: Junio C HamanoNext: Josh Steadmon
Message 42 of 99 in “test-tool: add unit test suite runner”
  1. 0/4 test-tool: add unit test suite runnerJosh Steadmon, Jan 16, 2024
  2. 1/4 t0080: turn t-basic unit test into a helperJosh Steadmon, Jan 16, 2024
  3. Junio C HamanoJan 16, 2024
  4. Jeff KingJan 23, 2024
  5. Josh SteadmonFeb 1, 2024
  6. 2/4 test-tool run-command testsuite: support unit testsJosh Steadmon, Jan 16, 2024
  7. Junio C HamanoJan 16, 2024
  8. Junio C HamanoJan 16, 2024
  9. Jeff KingJan 23, 2024
  10. Josh SteadmonFeb 1, 2024
  11. Junio C HamanoFeb 1, 2024
  12. Josh SteadmonFeb 1, 2024
  13. Josh SteadmonFeb 1, 2024
  14. 3/4 unit tests: add rule for running with test-toolJosh Steadmon, Jan 16, 2024
  15. 4/4 t/Makefile: run unit tests alongside shell testsJosh Steadmon, Jan 16, 2024
  16. Junio C HamanoJan 16, 2024
  17. 0/6 test-tool: add unit test suite runnerJosh Steadmon, Feb 3, 2024
  18. 1/6 t0080: turn t-basic unit test into a helperJosh Steadmon, Feb 3, 2024
  19. Junio C HamanoFeb 7, 2024
  20. Josh SteadmonFeb 12, 2024
  21. Jeff KingFeb 7, 2024
  22. Junio C HamanoFeb 8, 2024
  23. Josh SteadmonFeb 12, 2024
  24. Junio C HamanoFeb 12, 2024
  25. Jeff KingFeb 13, 2024
  26. rsbecker@nexbridge.comFeb 13, 2024
  27. Josh SteadmonFeb 22, 2024
  28. rsbecker@nexbridge.comFeb 23, 2024
  29. Junio C HamanoFeb 13, 2024
  30. Josh SteadmonFeb 22, 2024
  31. 2/6 test-tool run-command testsuite: get shell from envJosh Steadmon, Feb 3, 2024
  32. Junio C HamanoFeb 7, 2024
  33. Josh SteadmonFeb 12, 2024
  34. 3/6 test-tool run-command testsuite: remove hardcoded filterJosh Steadmon, Feb 3, 2024
  35. Junio C HamanoFeb 7, 2024
  36. Josh SteadmonFeb 12, 2024
  37. Junio C HamanoFeb 12, 2024
  38. 4/6 test-tool run-command testsuite: support unit testsJosh Steadmon, Feb 3, 2024
  39. phillip.wood123@gmail.comFeb 5, 2024
  40. Josh SteadmonFeb 12, 2024
  41. Junio C HamanoFeb 7, 2024
  42. Josh SteadmonFeb 23, 2024
  43. 5/6 unit tests: add rule for running with test-toolJosh Steadmon, Feb 3, 2024
  44. Junio C HamanoFeb 7, 2024
  45. 6/6 t/Makefile: run unit tests alongside shell testsJosh Steadmon, Feb 3, 2024
  46. Junio C HamanoFeb 7, 2024
  47. Jeff KingFeb 7, 2024
  48. Junio C HamanoFeb 7, 2024
  49. Junio C HamanoFeb 3, 2024
  50. Josh SteadmonFeb 12, 2024
  51. Junio C HamanoFeb 7, 2024
  52. 0/7 test-tool: add unit test suite runnerJosh Steadmon, Feb 23, 2024
  53. 1/7 t0080: turn t-basic unit test into a helperJosh Steadmon, Feb 23, 2024
  54. 2/7 test-tool run-command testsuite: get shell from envJosh Steadmon, Feb 23, 2024
  55. 3/7 test-tool run-command testsuite: remove hardcoded filterJosh Steadmon, Feb 23, 2024
  56. 4/7 test-tool run-command testsuite: support unit testsJosh Steadmon, Feb 23, 2024
  57. 5/7 unit tests: add rule for running with test-toolJosh Steadmon, Feb 23, 2024
  58. 6/7 t/Makefile: run unit tests alongside shell testsJosh Steadmon, Feb 23, 2024
  59. Jeff KingMar 27, 2024
  60. Josh SteadmonApr 11, 2024
  61. Jeff KingApr 12, 2024
  62. Josh SteadmonApr 24, 2024
  63. 7/7 ci: use test-tool as unit test runner on WindowsJosh Steadmon, Feb 23, 2024
  64. Junio C HamanoMar 26, 2024
  65. Jeff KingMar 27, 2024
  66. 0/7 test-tool: add unit test suite runnerJosh Steadmon, Apr 24, 2024
  67. 1/7 t0080: turn t-basic unit test into a helperJosh Steadmon, Apr 24, 2024
  68. 2/7 test-tool run-command testsuite: get shell from envJosh Steadmon, Apr 24, 2024
  69. 3/7 test-tool run-command testsuite: remove hardcoded filterJosh Steadmon, Apr 24, 2024
  70. 4/7 test-tool run-command testsuite: support unit testsJosh Steadmon, Apr 24, 2024
  71. 5/7 unit tests: add rule for running with test-toolJosh Steadmon, Apr 24, 2024
  72. 6/7 t/Makefile: run unit tests alongside shell testsJosh Steadmon, Apr 24, 2024
  73. Junio C HamanoApr 24, 2024
  74. Josh SteadmonApr 30, 2024
  75. Jeff KingMay 3, 2024
  76. Junio C HamanoMay 3, 2024
  77. Josh SteadmonMay 6, 2024
  78. 7/7 ci: use test-tool as unit test runner on WindowsJosh Steadmon, Apr 24, 2024
  79. 0/7 test-tool: add unit test suite runnerJosh Steadmon, Apr 30, 2024
  80. 1/7 t0080: turn t-basic unit test into a helperJosh Steadmon, Apr 30, 2024
  81. 2/7 test-tool run-command testsuite: get shell from envJosh Steadmon, Apr 30, 2024
  82. 3/7 test-tool run-command testsuite: remove hardcoded filterJosh Steadmon, Apr 30, 2024
  83. 4/7 test-tool run-command testsuite: support unit testsJosh Steadmon, Apr 30, 2024
  84. 5/7 unit tests: add rule for running with test-toolJosh Steadmon, Apr 30, 2024
  85. 6/7 t/Makefile: run unit tests alongside shell testsJosh Steadmon, Apr 30, 2024
  86. Junio C HamanoApr 30, 2024
  87. Josh SteadmonMay 6, 2024
  88. 7/7 ci: use test-tool as unit test runner on WindowsJosh Steadmon, Apr 30, 2024
  89. Junio C HamanoApr 30, 2024
  90. Josh SteadmonMay 6, 2024
  91. 0/7 test-tool: add unit test suite runnerJosh Steadmon, May 6, 2024
  92. 1/7 t0080: turn t-basic unit test into a helperJosh Steadmon, May 6, 2024
  93. 2/7 test-tool run-command testsuite: get shell from envJosh Steadmon, May 6, 2024
  94. 3/7 test-tool run-command testsuite: remove hardcoded filterJosh Steadmon, May 6, 2024
  95. 4/7 test-tool run-command testsuite: support unit testsJosh Steadmon, May 6, 2024
  96. 5/7 unit tests: add rule for running with test-toolJosh Steadmon, May 6, 2024
  97. 6/7 t/Makefile: run unit tests alongside shell testsJosh Steadmon, May 6, 2024
  98. 7/7 ci: use test-tool as unit test runner on WindowsJosh Steadmon, May 6, 2024
  99. Junio C HamanoMay 6, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.