From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 03 May 2024 19:17:45 GMT
Subject: Re: [PATCH v4 6/7] t/Makefile: run unit tests alongside shell tests
Message-ID: <xmqq34qy7lie.fsf@gitster.g>
In-Reply-To: <20240503180239.GA3634479@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> 	if test -z "${TEST_SHELL_PATH:+set}"
>> 	then
>> 		echo >&2 "ERROR: TEST_SHELL_PATH is not set or empty"
>> 
>> may be what we want here.
>
> If we are using ":+" to handle the empty string, I think just:
>
>   if test -z "$TEST_SHELL_PATH"
>
> is sufficient, no?

Yes. And the other part of this hunk still needs fixing, namely,

> +		exit 1
> +	fi
> +	exec ${TEST_SHELL_PATH} "$@"
> +	;;

the above reference needs to be quoted protect $IFS in the path.