Re: [RFC PATCH v2 4/6] test-tool run-command testsuite: support unit tests
- From
Josh Steadmon <steadmon@google.com>
- Date
- Feb 12, 2024, 21:15 UTC
- Message-ID
- <ZcqKbV37GDfNb4oF@google.com>
- In-Reply-To
- <4e2cbadd-1e0c-4526-a50f-9ba8600e7788@gmail.com>
On 2024.02.05 16:16, phillip.wood123@gmail.com wrote:
Show 19 quoted lines
> Hi Josh > > On 03/02/2024 00:50, Josh Steadmon wrote: > > Teach the testsuite runner in `test-tool run-command testsuite` how to > > run unit tests: if TEST_SHELL_PATH is not set, assume that we're running > > the programs directly from CWD, rather than defaulting to "sh" as an > > interpreter. > > Judging from the last patch in this series it seems likely that we'll want > to run unit tests and integration tests parallel. In which case it might be > better to look at the filename extension to decide whether to sh as an > interpreter so that we can avoid having to use a wrapper script. Then > > cd t > helper/test-tool run-command testsuite 't[0-9]*.sh' 'unit-tests/bin/*' > > would run the integration tests via "sh" and the unit-tests directly. We'd > need to figure out how to look for tests in both directories as well > though...
At the moment, I'm not planning on trying to make unit tests and shell tests run under the same test-tool process. If that is a valuable change, hopefully the Windows / CI experts can use this series as a starting point to make additional test-tool changes. However, I will probably not spend any further time on this area.