Re: [PATCH] pager: die when paging to non-existing command
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 20, 2024, 21:03 UTC
- Message-ID
- <xmqq34p7tjhd.fsf@gitster.g>
- In-Reply-To
- <73b9a923-c3d6-46e8-b050-e8a93b9757a2@gmail.com>
Rubén Justo <rjusto@gmail.com> writes:
Show 18 quoted lines
> On Thu, Jun 20, 2024 at 12:04:03PM -0700, Junio C Hamano wrote:
>
>> > + die("unable to start the pager: '%s'", pager);
>>
>> If this error string is not used elsewhere, it probably is a good
>> idea to "revert" to the original error message lost by ea27a18c,
>> which was:
>>
>> die("unable to execute pager '%s'", pager);
>
> Makes sense. Let me know if you need me to reroll.
>
>> Just in case there is a reason why we should instead silently return
>> on MinGW, I'll Cc the author of bfdd9ffd, though.
>
> Yup. I did notice the MINGW conditions in t7006 but, to be honest, I
> hadn't thought about this. Thank you for considering it and seeking
> confirmation.After these questions are answered satisfactory, can you send an updated version to conclude the topic?
Thanks.