Re: [PATCH] pager: die when paging to non-existing command

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 24, 2024, 07:35 UTC
Message-ID: <ecf29882-c192-e6f5-64f9-ac4cedb5d85d@gmx.de>
In-Reply-To: <ba5965c2-9f1c-4dd2-a2c5-e1bde832766c@kdbg.org>

Hi Hannes,

On Fri, 21 Jun 2024, Johannes Sixt wrote:

Show 7 quoted lines

> Am 20.06.24 um 21:04 schrieb Junio C Hamano:
> > Just in case there is a reason why we should instead silently return
> > on MinGW, I'll Cc the author of bfdd9ffd, though.
>
> I don't think there is a reason. IIRC, originally on Windows, failing to
> start a pager would still let Git operate normally, just without paged
> output. I might have regarded this as better than to fail the operation.

I recall regarding this a much better idea back then, too, because it was quite finicky to convince the MinGW variant of Git to play nice with the MSys variant of the pager.

In the meantime, things have become a lot more robust and consider it a net improvement to the change the behavior to _not_ silently continue if the pager failed to start.

Ciao, Johannes