git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pager: die when paging to non-existing command

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Jun 21, 2024, 11:28 UTC
Message-ID
<ab50c9e6-e43a-47fb-b64a-136d6a768f75@gmail.com>
In-Reply-To
<xmqqsex7tp0c.fsf@gitster.g>
On 20/06/2024 20:04, Junio C Hamano wrote:
Show 15 quoted lines
> Rubén Justo <rjusto@gmail.com> writes:
>> --- a/pager.c
>> +++ b/pager.c
>> @@ -137,7 +137,7 @@ void setup_pager(void)
>>   	pager_process.in = -1;
>>   	strvec_push(&pager_process.env, "GIT_PAGER_IN_USE");
>>   	if (start_command(&pager_process))
>> -		return;
>> +		die("unable to start the pager: '%s'", pager);
> 
> If this error string is not used elsewhere, it probably is a good
> idea to "revert" to the original error message lost by ea27a18c,
> which was:
> 
> 		die("unable to execute pager '%s'", pager);
Either way I think we want to mark the message for translation
Best Wishes
Phillip
Previous: Johannes SchindelinNext: Junio C Hamano
Message 10 of 17 in “pager: die when paging to non-existing command”
  1. pager: die when paging to non-existing commandRubén Justo, Jun 20, 2024
  2. Junio C HamanoJun 20, 2024
  3. Rubén JustoJun 20, 2024
  4. Junio C HamanoJun 20, 2024
  5. Johannes SixtJun 20, 2024
  6. Junio C HamanoJun 20, 2024
  7. Jeff KingJun 21, 2024
  8. Dragan SimicJun 21, 2024
  9. Johannes SchindelinJun 24, 2024
  10. Phillip WoodJun 21, 2024
  11. Junio C HamanoJun 21, 2024
  12. Jeff KingJun 21, 2024
  13. Rubén JustoJun 21, 2024
  14. pager: die when paging to non-existing commandRubén Justo, Jun 21, 2024
  15. pager: die when paging to non-existing commandRubén Justo, Jun 21, 2024
  16. Johannes SixtJun 22, 2024
  17. pager: die when paging to non-existing commandRubén Justo, Jun 23, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.