Re: [PATCH] pager: die when paging to non-existing command
On 20/06/2024 20:04, Junio C Hamano wrote:
Show 15 quoted lines
> Rubén Justo <rjusto@gmail.com> writes:
>> --- a/pager.c
>> +++ b/pager.c
>> @@ -137,7 +137,7 @@ void setup_pager(void)
>> pager_process.in = -1;
>> strvec_push(&pager_process.env, "GIT_PAGER_IN_USE");
>> if (start_command(&pager_process))
>> - return;
>> + die("unable to start the pager: '%s'", pager);
>
> If this error string is not used elsewhere, it probably is a good
> idea to "revert" to the original error message lost by ea27a18c,
> which was:
>
> die("unable to execute pager '%s'", pager);Either way I think we want to mark the message for translation
Best Wishes
Phillip