Re: [PATCH v3] pager: die when paging to non-existing command

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 22, 2024, 07:08 UTC
Message-ID: <f031c152-1b97-4598-92f3-a72aefd701a4@kdbg.org>
In-Reply-To: <6850f558-ad20-403a-ae1e-5b9826c53790@gmail.com>

Am 22.06.24 um 01:31 schrieb Rubén Justo:

Show 9 quoted lines

> Let's make the error clear by aborting the process and return an error
> so that the user can easily correct their mistake.
> 
> This will be the result of the change:
> 
>     $ GIT_PAGER=non-existent t/test-terminal.perl git log | wc -c
>     error: cannot run non-existent: No such file or directory
>     fatal: unable to start the pager: 'non-existent'
>     0

Not a big deal, but the error message cited here does not match the actual new text:

>  	if (start_command(&pager_process))
> -		return;
> +		die("unable to execute pager '%s'", pager);

-- Hannes