Re: [PATCH] pager: die when paging to non-existing command

From

Rubén Justo <rjusto@gmail.com>

Date

Jun 20, 2024, 20:22 UTC

Message-ID

<73b9a923-c3d6-46e8-b050-e8a93b9757a2@gmail.com>

In-Reply-To

<xmqqsex7tp0c.fsf@gitster.g>

On Thu, Jun 20, 2024 at 12:04:03PM -0700, Junio C Hamano wrote:

> > +		die("unable to start the pager: '%s'", pager);
> 
> If this error string is not used elsewhere, it probably is a good
> idea to "revert" to the original error message lost by ea27a18c,
> which was:
> 
> 		die("unable to execute pager '%s'", pager);

Makes sense.  Let me know if you need me to reroll.

> Just in case there is a reason why we should instead silently return
> on MinGW, I'll Cc the author of bfdd9ffd, though.