Re: [PATCH 4/5] pack-write: pass hash_algo to `write_rev_file()`

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 16, 2025, 19:35 UTC
Message-ID: <xmqq34hir1qk.fsf@gitster.g>
In-Reply-To: <20250116-kn-the-repo-cleanup-v1-4-a2f4c8e1c4c3@gmail.com>

Karthik Nayak via B4 Relay <devnull+karthik.188.gmail.com@kernel.org> writes:

Show 5 quoted lines

> From: Karthik Nayak <karthik.188@gmail.com>
>
> The `write_rev_file()` function uses the global `the_hash_algo` variable
> to access the repository's hash function. To avoid global variable
> usage, let's pass the hash function from the layers above.

There are a few other functions that got an extra git_hash_algo parameter in this patch. The changes to them all look sensible, but it would be nice to mention them here.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.