From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 16 Jan 2025 19:35:15 GMT
Subject: Re: [PATCH 4/5] pack-write: pass hash_algo to `write_rev_file()`
Message-ID: <xmqq34hir1qk.fsf@gitster.g>
In-Reply-To: <20250116-kn-the-repo-cleanup-v1-4-a2f4c8e1c4c3@gmail.com>

Karthik Nayak via B4 Relay
<devnull+karthik.188.gmail.com@kernel.org> writes:

> From: Karthik Nayak <karthik.188@gmail.com>
>
> The `write_rev_file()` function uses the global `the_hash_algo` variable
> to access the repository's hash function. To avoid global variable
> usage, let's pass the hash function from the layers above.

There are a few other functions that got an extra git_hash_algo
parameter in this patch.  The changes to them all look sensible,
but it would be nice to mention them here.