Re: [PATCH v2 1/5] pack-write: pass hash_algo to `fixup_pack_header_footer()`

From: Toon Claes <toon@iotcl.com>
Date: Jan 17, 2025, 16:38 UTC
Message-ID: <87zfjpiefc.fsf@iotcl.com>
In-Reply-To: <20250117-kn-the-repo-cleanup-v2-1-a7fdc19688f5@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> The `fixup_pack_header_footer()` function uses the global
> `the_hash_algo` variable to access the repository's hash function. To
> avoid global variable usage, pass the hash function from the layers
> above.

I'm probably being overly pedantic here, so feel free to ignore me. But you say "pass the hash function", technically that's not correct, you're passing down the struct that defines several properties of the hashing algorithm. This includes the hash function, but also other properties like the hex size. By using "pass the hash function" in the commit messages (and not only this commit message) it sounds to me like you're changing the type of the object that desribes the "hash algo". But again, feel free to ignore this comment.

-- 
Toon