Re: [PATCH 3/5] pack-write: pass hash_algo to `write_idx_file()`

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 17, 2025, 08:56 UTC
Message-ID: <CAOLa=ZTGzEwKp7LtXGnHLo1cayryXouy1MCLPrNRCXPzgXk4rw@mail.gmail.com>
In-Reply-To: <Z4kIg8ihbgPPb3C_@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 15 quoted lines

> On Thu, Jan 16, 2025 at 12:35:15PM +0100, Karthik Nayak via B4 Relay wrote:
>> @@ -546,7 +547,8 @@ void rename_tmp_packfile_idx(struct strbuf *name_buffer,
>>  	rename_tmp_packfile(name_buffer, *idx_tmp_name, "idx");
>>  }
>>
>> -void stage_tmp_packfiles(struct strbuf *name_buffer,
>> +void stage_tmp_packfiles(const struct git_hash_algo *hash_algo,
>> +			 struct strbuf *name_buffer,
>>  			 const char *pack_tmp_name,
>>  			 struct pack_idx_entry **written_list,
>>  			 uint32_t nr_written,
>
> This change was somewhat unexpected to me as it wasn't mentioned, so it
> makes you wonder why it's different than `wried_idx_file()`.
>

Should've mentioned it. This was also modified since it exists in 'pack-write.c'. Will amend the commit message.

> Patrick