Re: [PATCH 2/5] pack-write: pass repository to `index_pack_lockfile()`

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 17, 2025, 08:47 UTC
Message-ID: <CAOLa=ZTF_2Gq9sFZqwu3Sw2dcQficBW3FOVeJnBDuwc5n4e-gg@mail.gmail.com>
In-Reply-To: <xmqqo706r34s.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Karthik Nayak via B4 Relay
> <devnull+karthik.188.gmail.com@kernel.org> writes:
>
>> From: Karthik Nayak <karthik.188@gmail.com>
>>
>> The `index_pack_lockfile()` function uses the global `the_repository`
>> variable to access the repository. To avoid global variable usage, pass
>> the repository from the layers above.
>>
>> Altough the layers above could have access to the hash function
>
> I do not think the choice of the hash algorithm has much to do with
> this change, though ;-)
>

Oops, copy-paste error. Thanks for pointing out, will fix.

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.