Re: [PATCH] ci: github action - add check for whitespace errors

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 22, 2020, 17:55 UTC
Message-ID: <xmqq1ritlmrk.fsf@gitster.c.googlers.com>
In-Reply-To: <20200922170745.GA541915@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

>  - this will run only on PRs. That's helpful for people using
>    GitGitGadget, but it might also be useful for people just running the
>    CI by pushing branches, or looking at CI builds of Junio's next or
>    seen branches. Could we make it work there? Obviously we wouldn't be
>    able to rely on having PR data, but I wonder if "git log
>    HEAD..$branch" would be sufficient.

Yes, I like that very much. If a push triggers a CI run to notice whitespace breakage and other mechanically detectable errors, that would prevent embarrassment before even a pull request is opened.

For me, 'next' is way too late to catch mechanically detectable errors, but an extra set of eyes, even mechanical ones, on the tip of 'seen' is always appreciated.

Thanks.