Re: [PATCH] ci: github action - add check for whitespace errors

From: Chris Webster <chris@webstech.net>
Date: Sep 22, 2020, 22:17 UTC
Message-ID: <CAGT1KpVmeT+nT1-Pfwa_M8BptFYwRTL4ofM0k6UOOzkYh0kucw@mail.gmail.com>
In-Reply-To: <20200922170745.GA541915@coredump.intra.peff.net>

On Tue, Sep 22, 2020 at 10:07 AM Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

>  - for a linear branch on top of master, using the commit count will
>    work reliably. But I suspect it would run into problems if there were
>    ever a merge on a PR (e.g., back-merging from master), where we'd be
>    subject to how `git log` linearizes the commits. That's not really a
>    workflow I'd expect people to use with git.git, but it would probably
>    be easy to make it more robust. Does the PR object provide the "base"
>    oid, so we could do "git log $base..$head"?

GitGitGadget PR linting is going to flag merges in the PR and request a rebase. If I understand correctly, that means back-merging is not part of the workflow. The checkout is limited to improve performance and reduce resources. In the PR object, the base is the branch. The github api would need to be used to get more detailed information. The "base" is not really part of the checkout so it can not be referenced in the git log command (without doing a larger checkout).

...chris.