Re: [PATCH] ci: github action - add check for whitespace errors

From: Chris Webster <chris@webstech.net>
Date: Sep 25, 2020, 05:10 UTC
Message-ID: <CAGT1KpU6zkvr9QQQqez6x1cVsvhxmkU9gG5T0QYC8yCgnOPN1Q@mail.gmail.com>
In-Reply-To: <20200924065129.GB1851751@coredump.intra.peff.net>

On Wed, Sep 23, 2020 at 11:51 PM Jeff King <peff@peff.net> wrote:

Show 9 quoted lines

>   git clone --shallow-exclude=HEAD --single-branch -b $branch
>   git log --check
>
> _almost_ works. The problem is that the shallow graft means that the
> bottom commit looks like it introduces every file. We really want to
> graft at HEAD^, but the server side only accepts exact refnames. You
> could work around it with a followup:
>
>   git fetch --deepen 1

Thanks for the other possibilities (I have much to learn). The first step to increase the commit count is addressing this very problem.

> Definitely not worth
> it compared to your solution for a PR, but maybe worth it if it lets us
> do the same thing for arbitrary branches.

The PR solution works because fixed values are available from GitHub (both repos are present and accounted for). A push action for branches could have issues with the state of the GitHub repo versus the local repo. What happens if the base branch is not current on GitHub? Is HEAD reliable? What if the branch has been re-used with a back-merge? How do you limit the check in this case? Based on my demonstrated lack of knowledge these concerns may be addressable.

The original push solution pulled an arbitrary depth knowing GitGitGadget had a limit of 30 commits and then limited the check to post merge commits, again knowing merges were flagged. Not pretty but workable in the confines of the GitGitGadget workflow.

A generic push solution (with an opt out?) could be a separate file or replace this (yea).

I appreciate the feedback, ...chris.