Re: [PATCH] ci: github action - add check for whitespace errors

From: Jeff King <peff@peff.net>
Date: Oct 9, 2020, 17:59 UTC
Message-ID: <20201009175917.GA963340@coredump.intra.peff.net>
In-Reply-To: <xmqqtuv3tlkv.fsf@gitster.c.googlers.com>

On Fri, Oct 09, 2020 at 09:23:28AM -0700, Junio C Hamano wrote:

Show 20 quoted lines

> I think this is exactly the use case that
> 
>     After the list reached a consensus that it is a good idea to apply the
>     patch, re-send it with "To:" set to the maintainer{current-maintainer}
>     and "cc:" the list{git-ml} for inclusion.
> 
> in Documentation/SubmittingPatches was written to address.
> 
> I usually pay attention to majority of topics and have them on my
> radar by getting involved in _some_ way in the discussion thread, so
> I often know when the patch(es) matured enough to be picked up
> without such a "this is the version after our discussion and it is
> as close to perfect as we can possibly make" resend.
> 
> But for some topics, I have no strong opinion on the exact shape of
> the final patch(es), and/or I have no expertise to offer to help the
> discussion to reach the final product.  In such a case, I'd be just
> waiting, without getting involved in the discussion, for trusted
> others to bring the posted patch to a completed form.  I think this
> is such a case.

As the other person in the discussion, I'm sufficiently convinced that doing this just for PRs is a good step for now. I.e., I think the "completed form" is just what was posted already (though I agree it is often convenient to the maintainer to re-post the patch as part of the ping).

-Peff