git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ci: github action - add check for whitespace errors

From
Jeff King <peff@peff.net>
Date
Oct 9, 2020, 18:18 UTC
Message-ID
<20201009181827.GA965760@coredump.intra.peff.net>
In-Reply-To
<xmqqeem7tgh4.fsf@gitster.c.googlers.com>
On Fri, Oct 09, 2020 at 11:13:43AM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> > As the other person in the discussion, I'm sufficiently convinced that
> > doing this just for PRs is a good step for now. I.e., I think the
> > "completed form" is just what was posted already (though I agree it is
> > often convenient to the maintainer to re-post the patch as part of the
> > ping).
> 
> Yes, and CC'ing those who were involved in the review would give
> them the last chance to say "oh, no, that extra change you added
> for this final submission was not something I meant to suggest!",
> etc.
> 
> So, is <pull.709.git.1600759684548.gitgitgadget@gmail.com> as-is the
> one we should take?

AFAIK it's the only one on the list. :) So yes, that one is fine with me.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 17 in “ci: github action - add check for whitespace errors”
  1. ci: github action - add check for whitespace errorsChris. Webster via GitGitGadget, Sep 22, 2020
  2. Jeff KingSep 22, 2020
  3. Junio C HamanoSep 22, 2020
  4. Chris WebsterSep 22, 2020
  5. Chris WebsterOct 9, 2020
  6. Johannes SchindelinOct 9, 2020
  7. Junio C HamanoOct 9, 2020
  8. Jeff KingOct 9, 2020
  9. Junio C HamanoOct 9, 2020
  10. Jeff KingOct 9, 2020
  11. Junio C HamanoOct 9, 2020
  12. Chris WebsterOct 10, 2020
  13. Junio C HamanoOct 10, 2020
  14. Chris WebsterSep 22, 2020
  15. Jeff KingSep 24, 2020
  16. Chris WebsterSep 25, 2020
  17. Jeff KingSep 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.