Re: [PATCH v3 1/3] diff: return diff_filepair from diff queue helpers

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 26, 2025, 18:04 UTC
Message-ID: <xmqq1pvkeg5o.fsf@gitster.g>
In-Reply-To: <20250225233925.1345086-2-jltobler@gmail.com>

Justin Tobler <jltobler@gmail.com> writes:

> separate functions are implemented instead.

It would have been more assuring to explicitly say that the original functions that discarded the newly created filepair after adding them to the queue are reimplemented as thin wrappers, which is the right thing to do and which is exactly what happens in this patch.

Looking good.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.