Re: [PATCH 0/3] batch blob diff generation

From: Jeff King <peff@peff.net>
Date: Dec 16, 2024, 11:11 UTC
Message-ID: <20241216111112.GA2201417@coredump.intra.peff.net>
In-Reply-To: <xmqq5xnladwi.fsf@gitster.g>

On Sat, Dec 14, 2024 at 06:17:01PM -0800, Junio C Hamano wrote:

Show 14 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Yeah, you're right.  I forgot about attr.tree (does not seem to be
> > documented, by the way)
> 
> We do have an entry in Documentation/config/attr.txt that describes
> the three; I simply assumed it is not documented as I didn't see it
> mentioned in Documentation/git.txt where --attr-source &
> GIT_ATTR_SOURCE are described.
> 
> We may want to add something like this, perhaps?
> 
> ----- >8 -----
> Subject: doc: give attr.tree a bit more visibility

Yeah, that looks good to me.

I recall that the performance of attr.tree is not great for _some_ commands (like pack-objects). So it's perhaps reasonable to use for single commands like "git diff" but not to set in your on-disk config. It's possible we'd want to warn people about that before advertising it more widely? I dunno.

-Peff