Re: [PATCH 0/3] batch blob diff generation

From: Jeff King <peff@peff.net>
Date: Dec 13, 2024, 10:38 UTC
Message-ID: <20241213103850.GA1456983@coredump.intra.peff.net>
In-Reply-To: <xmqqv7vnevjc.fsf@gitster.g>

On Fri, Dec 13, 2024 at 07:17:59PM +0900, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Feeding just blob ids has a big drawback: we don't have any context! So
> > you get bogus filenames in the patch, no mode data, and so on.
> 
> And the lack of filenames and the tree object name at the root level
> means you do not get anything out of the attribute subsystem, which
> in turn may affect a few more things.
> 
> Unfortunately the format used in the output from "diff --raw" does
> not capture this.

Don't we just use the working tree .gitattributes by default, and ignore what's in the endpoints? In a bare repo we wouldn't have that, but I think the recently added attr.tree and --attr-source options would work there.

You can't use attributes from multiple trees in a single request, but I doubt that would be a big drawback.

-Peff