Re: [PATCH 0/3] batch blob diff generation

> > Ah, OK.  So your "caution" was about the underlying mechanism to
> > allow attributes corrected from the specified tree, and not
> > specifically about using "attr.tree" to specify that tree?  That was
> > what got me confused.
> > 
> > If that is the case, I do not think the documentation patch that
> > started this exchange that adds attr.tree to where GIT_ATTR_SOURCE
> > and --attr-source are already mentioned makes anything worse.
> 
> Yeah, I agree it's somewhat orthogonal. Your patch made me think about
> it because it is advertising the config variant more widely. Somebody
> doing:
> 
>   git --attr-source=foo diff ...
> 
> is probably OK, but:
> 
>   git --attr-source=foo pack-objects ...
> 
> is less so. Using attr.tree instead means you're going to do the latter
> whether you intended to or not.