Re: [PATCH] rebase [-i --exec | -ix] <CMD>...

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 4, 2012, 20:30 UTC
Message-ID: <vpqk3zmn7k1.fsf@bauges.imag.fr>
In-Reply-To: <7vhaurt1m6.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> The description of this and exisitng <newbase> look very odd.  The
> usual way to describe an option that take a parameter in the OPTIONS
> section is to instead do:
>
> 	--onto <newbase>::
> 		Description of what --onto option does and how <newbase>
> 		is used in what it does.
>
> 	--exec <cmd>::
> 		Description of what --exec option does, and how	<cmd> 
>                 is used in what it does.

(to the authors: you can add a trivial patch to fix the --onto doc, and base your work on it)

> Why is "pick" special?  Don't you want to run the commands after
> "edit", "reword", "squash", "fixup"?

I'd actually say you want to run it after a squash/fixup serie only.

If the result of --autosquash is

pick foo fixup bar fixup boz pick foobar

I think you want to rewrite it as

pick foo fixup bar fixup boz exec make pick foobar exec make

The command is typically used to check that each new commit is OK, but we can forget about the intermediate states as we are precisely getting rid of them.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/