Re: [PATCHv5] rebase [-i --exec | -ix] <CMD>...

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2012, 18:22 UTC
Message-ID: <7vipevgjhp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120613200552.Horde.JHFYfHwdC4BP2NaA39-wrmA@webmail.minatec.grenoble-inp.fr>

konglu@minatec.inpg.fr writes:

Show 13 quoted lines

>> +You may execute several commands by either using one instance of `--exec`
>> +with several commands:
>>  +
>> -You can also insert several instances of `--exec`, if you wish to only
>> -have one command per line. For example:
>> +	git rebase -i --exec "cmd1 && cmd2 && ..."
>>  +
>> -	git rebase -i --exec "cmd1" --exec "cmd2" ...
>> +or equivalently by giving more than one `--exec`:
>
> ...I'm against using "equivalently" as in the first case, all the commands
> are on one line, and in the second case, each commands have its line, thus
> easier for the user to manipulate them independently.

It looks that editing

    pick foo            pick foo
    exec cmd1           exec cmd1 && cmd2
    exec cmd2
    pick bar            pick bar
    exec cmd1           exec cmd1 && cmd2
    exec cmd2

to

    pick foo            pick foo
                        exec         cmd2
    exec cmd2
    pick bar            pick bar
    exec cmd1           exec cmd1

would take exactly the same effort, at least to me. And more importantly, without editing don't they do *exactly* the same thing? If cmd1 fails, the sequencing stops at that step without running cmd2.