Re: [PATCH] rebase [-i --exec | -ix] <CMD>...
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 5, 2012, 18:13 UTC
- Message-ID
- <7vtxypocdf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120605195959.Horde.h42jfHwdC4BPzkkfVQizm9A@webmail.minatec.grenoble-inp.fr>
konglu@minatec.inpg.fr writes:
> But shouldn't we keep the "test `expr substr "$2" 1 1` = -" part so that > options can't be right after the "--exec" ?
No. We have no reason to forbid users from giving their commands names that begin with "-", and if it is a typo, "exec" machinery will catch it and tell the user "no such command". I do not see any good reason to be clever in the part of the command parsing loop that handles "--exec <cmd>" option.