Re: [PATCHv5] rebase [-i --exec | -ix] <CMD>...

From: konglu@minatec.inpg.fr <konglu@minatec.inpg.fr>
Date: Jun 13, 2012, 19:38 UTC
Message-ID: <20120613213836.Horde.qI8GQnwdC4BP2Ow8uCTQqgA@webmail.minatec.grenoble-inp.fr>
In-Reply-To: <7vipevgjhp.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> a écrit :

Show 20 quoted lines

> It looks that editing
>
>     pick foo            pick foo
>     exec cmd1           exec cmd1 && cmd2
>     exec cmd2
>     pick bar            pick bar
>     exec cmd1           exec cmd1 && cmd2
>     exec cmd2
>
> to
>
>     pick foo            pick foo
>                         exec         cmd2
>     exec cmd2
>     pick bar            pick bar
>     exec cmd1           exec cmd1
>
> would take exactly the same effort, at least to me.  And more
> importantly, without editing don't they do *exactly* the same thing?
> If cmd1 fails, the sequencing stops at that step without running cmd2.

True. I was thinking under the fact that the user would edit the commands by himself but the purpose of the "--exec" option is to avoid that (or at least that the user won't have to type all by himself). Forget what I said then :).