Re: [PATCH 3/4] push: make non-fast-forward help message configurable

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sep 7, 2009, 08:34 UTC
Message-ID: <vpqeiqjf90u.fsf@bauges.imag.fr>
In-Reply-To: <20090907082430.GA17997@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> On Mon, Sep 07, 2009 at 09:44:57AM +0900, Nanako Shiraishi wrote:
>
>> You may be fixated at the sha1 part of the message when you find this
>> message annoying, but I disagree strongly. I always appreciate the
>> assurance this message gives me that I counted the number of commits
>> correctly, whether I say HEAD^^^^ or HEAD~7.
>
> Let me add a "me too" to Nanako's comments.

I guess it depends on one's workflow. If you usually cut-and-paste sha1's, then the message is superfluous, while if you usually use magic revspec, it is useful.

So, it's probably a good idea to make this configurable.

Show 5 quoted lines

> So really they are two different conceptual types of message. And while
> I have no problem with an argument of "I _personally_ find this clutter
> and would like to configure it off", I don't think such an option should
> go under "advice.*". My patch had "message.all" (which will become
> "advice.all")

To me, this is an argument in favor of keeping "message", to allow the same mechanism for these different types of messages.

But I think the individual message.* should not be just true/false switch, but could be always/auto/never :

- always: show the message, regardless of message.all
- auto (the default): rely on message.all to decide whether to show
  the message
- never: never show it.

So you could say "message.all = false" and "message.resetShowsNewHead = always".

But maybe that's just overkill, dunno...

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/