Re: [PATCH v3] git-latexdiff: new command in contrib, to use latexdiff and Git

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 16, 2012, 14:15 UTC
Message-ID: <vpq62f627b4.fsf@bauges.imag.fr>
In-Reply-To: <m3d39esxrg.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

> Nb. I think it would be good to put detecting PDF viewer in its own
> function, don't you?

I normally like functions, but for such a linear and small piece of code, I think it adds more confusion that clarity to write

do_fo () {
   actual stuff
}

do_foo

than the actual stuff alone.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.