Re: [PATCH v2] git-latexdiff: new command in contrib, to use latexdiff and Git

From: David Aguilar <davvid@gmail.com>
Date: Feb 16, 2012, 19:24 UTC
Message-ID: <CAJDDKr5SrDoVyd8s7pE3WMQ_c_DiSiiwHTz0O0t2TM24fCb-Aw@mail.gmail.com>
In-Reply-To: <1329381560-15853-1-git-send-email-Matthieu.Moy@imag.fr>

On Thu, Feb 16, 2012 at 12:39 AM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:

Show 6 quoted lines

> +
> +verbose () {
> +    if [ "$verbose" = 1 ]; then
> +       printf "%s ..." "$@"
> +    fi
> +}

In addition to preferring "test" over "[", we also prefer to write these on several lines. It's probably time to update the CodingStyle document with these notes.

e.g.

if test "$verbose" = 1
then
    .... do stuff
fi

(with hard-tabs, not spaces (unlike my example))

-- 
David