From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 16 Feb 2012 14:15:27 GMT
Subject: Re: [PATCH v3] git-latexdiff: new command in contrib, to use latexdiff and Git
Message-ID: <vpq62f627b4.fsf@bauges.imag.fr>
In-Reply-To: <m3d39esxrg.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

> Nb. I think it would be good to put detecting PDF viewer in its own
> function, don't you?

I normally like functions, but for such a linear and small piece of
code, I think it adds more confusion that clarity to write

do_fo () {
   actual stuff
}

do_foo

than the actual stuff alone.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/