Re: [PATCH] git-latexdiff: new command in contrib, to use latexdiff and Git

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 17, 2012, 14:19 UTC
Message-ID: <vpqobsx7d9s.fsf@bauges.imag.fr>
In-Reply-To: <7vmx8hvb69.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> I agree that the next step may be to allow users of <whatever SCM
>> outside Git>, but I don't think the way to do that would be to make the
>> script generic. The script is a quick hack, and all the "clever" parts
>> of it are calls to Git.
>
> You are not suggesting me to take and carry any future request that wants
> to add any quick hack that is heavily specific to Git and not portable to
> other SCMs to the contrib/ area only because they depend on Git, are
> you?

I'm answering the remark you made:

| I have this suspicion that "this new version will help people who have
| their documents stored in Mercurial" would be much more realistic (and
| the end result being useful) than "this new version will help git users
| who do not write their documents in latex but in asciidoc".

I think the probability that a next version of git-latexdiff is to support another SCM is 0, and I tried to explain that.

Do you think I failed to address this remark?

> Look at what we have in the contrib/ area.  I think what is common among
> them is that their primary benefit is to enrich user's Git experience.

... and many of them is to enrich the user experience using Git with another tool (shell, text editor, foreign VCS).

Without git-latexdiff, you can run "git diff" on LaTeX documents, while with it, you can get a better view of the diff. To me, this is "enrich user's experience" of users running "git diff".

Git's _core_ already has some code to show diff hunks for various languages, and I don't think anyone would want to move these out because they only benefit people tracking files in these languages.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/