Re: [PATCH] git-latexdiff: new command in contrib, to use latexdiff and Git

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2012, 20:10 UTC
Message-ID: <7v8vk2zghl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpq39abrxav.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 12 quoted lines

> Tim Haga <timhaga@ebene6.org> writes:
>
>> While testing your script on my office machine i discovered that the
>> following might be a problem:
>>
>>> +if [ "$view" = 1 ] || [ "$view" = maybe ] && [ "$output" = "" ]; then
>>> +    xpdf "$pdffile"
>>> +fi
>>
>> Xpdf is not installed on all machines (e.g. it's not installed on my
>> office machine), so maybe it would be a good idea to use a environment
>> variable instead?

Honestly speaking, this is looking more like an "useful application for latex users who happen to use git to store their document source", and not a "useful addition for all git users", to me.

These two viewpoint suggests completely different evolution path for this program. Imagining what the first major new enhancement intended for people outside the original audience <git,latex> will be, I have this suspicion that "this new version will help people who have their documents stored in Mercurial" would be much more realistic (and the end result being useful) than "this new version will help git users who do not write their documents in latex but in asciidoc".

For that reason, I suspect that in the longer term, the tool will benefit more if I do not take this patch and the tool lives standalone.