[PATCH v2] [Outreachy PATCH] t2030: modernize test path checks

From: Srujith A Poojary via GitGitGadget <gitgitgadget@gmail.com>
Date: Oct 16, 2026, 07:25 UTC
Message-ID: <pull.2256.v2.git.1792135548923.gitgitgadget@gmail.com>
In-Reply-To: <pull.2256.git.1791978767497.gitgitgadget@gmail.com>

From: Srujith Poojary <poojarysrujith@gmail.com>

Replace old-style file checks with test_path_is_file and the helper

test_path_is_missing for clearer failure diagnostics in test output.

Search with: git grep "test -[efd]" t/

Signed-off-by: Srujith Poojary <poojarysrujith@gmail.com>
---
    t2030: modernize test path checks

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2256%2Fpoojarysrujith%2Fmicroproject-modernize-path-check-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2256/poojarysrujith/microproject-modernize-path-check-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/2256

Range-diff vs v1:

 1:  641b9330c9 ! 1:  93cf6c12f4 t2030: modernize test path checks
     @@ Metadata
      Author: Srujith Poojary <poojarysrujith@gmail.com>
      
       ## Commit message ##
     -    t2030: modernize test path checks
     +    [Outreachy PATCH] t2030: modernize test path checks
      
          Replace old-style file checks with test_path_is_file and the helper
     +
          test_path_is_missing for clearer failure diagnostics in test output.
      
          Search with: git grep "test -[efd]" t/

 t/t2030-unresolve-info.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t2030-unresolve-info.sh b/t/t2030-unresolve-info.sh
index 9af24b1204..56a7f849d6 100755
--- a/t/t2030-unresolve-info.sh
+++ b/t/t2030-unresolve-info.sh
@@ -170,7 +170,7 @@ test_expect_success 'rerere and rerere forget' '
 	git rerere &&
 	rerere_id=$(cd .git/rr-cache && echo */postimage) &&
 	rerere_id=${rerere_id%/postimage} &&
-	test -f .git/rr-cache/$rerere_id/postimage &&
+	test_path_is_file .git/rr-cache/$rerere_id/postimage &&
 	git checkout -m fi/le &&
 	echo resurrect the conflict &&
 	test_grep "^=======" fi/le &&
@@ -182,7 +182,7 @@ test_expect_success 'rerere and rerere forget' '
 	check_resolve_undo kept fi/le initial:fi/le second:fi/le third:fi/le &&
 	test -z "$(git ls-files -u)" &&
 	git rerere forget fi/le &&
-	! test -f .git/rr-cache/$rerere_id/postimage &&
+	test_path_is_missing .git/rr-cache/$rerere_id/postimage &&
 	tr "\0" "\n" <.git/MERGE_RR >actual &&
 	echo "$rerere_id	fi/le" >expect &&
 	test_cmp expect actual

base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd

-- 
gitgitgadget