Re: [PATCH v2] [Outreachy PATCH] t2030: modernize test path checks

From: Srujith Poojary <poojarysrujith@gmail.com>
Date: Oct 16, 2026, 10:16 UTC
Message-ID: <CABh_KWg58zWEBL-FydbOy5L31_datHfhXih5kcs1rge1a1LHng@mail.gmail.com>
In-Reply-To: <CAPSxiM8N4MjXpXjryxhx4170gEEQS6mfZu3+MQQ-1iRaFrxibQ@mail.gmail.com>

Hi Usman,

Thanks for the feedback!

Got it—I will remove the search command and update all four instances of test -f in that file, and I'll make sure to use inline replies and CC mentors going forward.

I'll send out the v3 patch shortly.

Thanks, Srujith A Poojary

On Fri, Oct 16, 2026 at 3:06 PM Usman Akinyemi <usmanakinyemi202@gmail.com> wrote:

Show 25 quoted lines

>
> > Thanks for taking a look at my patch!
> > Since this is for an Outreachy microproject, I kept the scope small to
> > follow the guidelines. But I completely understand—if it helps, I can
> > take a look at modernizing some of the other ones too in a separate
> > patch.
> Firstly, do not toppost when replying to a message at Git. Use inline comments.
> While the guidelines talked about keeping the changes small, which is valid.
> But, that file has about four instances of the same "test -f", that is
> not a big change.
> You can change all of those instances.
>
> The main idea of Microproject is to get you familiar with the Git workflow.
> > >
> > > Seems like a good change, but there are lots of these calls in the
> > > codebase. Maybe change the others ones too, while you're at it?
> Valid.
> > >
> > >
> > > Harald
> Thanks at Harald for the review.
>
> Thanks.
>
> Usman.