Re: [PATCH v2] [Outreachy PATCH] t2030: modernize test path checks

From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Oct 16, 2026, 09:35 UTC
Message-ID: <CAPSxiM8N4MjXpXjryxhx4170gEEQS6mfZu3+MQQ-1iRaFrxibQ@mail.gmail.com>
In-Reply-To: <CABh_KWi-MkiTY56LOLdaZu1dxxYjkSNX3jjO8+9_+mp3-FaNkg@mail.gmail.com>

Show 5 quoted lines

> Thanks for taking a look at my patch!
> Since this is for an Outreachy microproject, I kept the scope small to
> follow the guidelines. But I completely understand—if it helps, I can
> take a look at modernizing some of the other ones too in a separate
> patch.

Firstly, do not toppost when replying to a message at Git. Use inline comments. While the guidelines talked about keeping the changes small, which is valid. But, that file has about four instances of the same "test -f", that is not a big change. You can change all of those instances.

The main idea of Microproject is to get you familiar with the Git workflow.

> >
> > Seems like a good change, but there are lots of these calls in the
> > codebase. Maybe change the others ones too, while you're at it?

Valid.

> >
> >
> > Harald

Thanks at Harald for the review.

Thanks.

Usman.