Re: [PATCH v2] [Outreachy PATCH] t2030: modernize test path checks

From: Srujith Poojary <poojarysrujith@gmail.com>
Date: Oct 16, 2026, 08:50 UTC
Message-ID: <CABh_KWi-MkiTY56LOLdaZu1dxxYjkSNX3jjO8+9_+mp3-FaNkg@mail.gmail.com>
In-Reply-To: <CAHwyqnWT9f0FvthhsPcRb+c7j7xb1LBxGxxBheb_ddfcUqij+A@mail.gmail.com>

Hi Harald,

Thanks for taking a look at my patch! Since this is for an Outreachy microproject, I kept the scope small to follow the guidelines. But I completely understand—if it helps, I can take a look at modernizing some of the other ones too in a separate patch.

Thanks, Srujith A Poojary

On Fri, Oct 16, 2026 at 2:06 PM Harald Nordgren <haraldnordgren@gmail.com> wrote:

Show 17 quoted lines

>
> > +       test_path_is_file .git/rr-cache/$rerere_id/postimage &&
> >         git checkout -m fi/le &&
> >         echo resurrect the conflict &&
> >         test_grep "^=======" fi/le &&
> > @@ -182,7 +182,7 @@ test_expect_success 'rerere and rerere forget' '
> >         check_resolve_undo kept fi/le initial:fi/le second:fi/le third:fi/le &&
> >         test -z "$(git ls-files -u)" &&
> >         git rerere forget fi/le &&
> > -       ! test -f .git/rr-cache/$rerere_id/postimage &&
> > +       test_path_is_missing .git/rr-cache/$rerere_id/postimage &&
>
> Seems like a good change, but there are lots of these calls in the
> codebase. Maybe change the others ones too, while you're at it?
>
>
> Harald