Re: [PATCH v2] [Outreachy PATCH] t2030: modernize test path checks

From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Oct 16, 2026, 08:36 UTC
Message-ID: <CAHwyqnWT9f0FvthhsPcRb+c7j7xb1LBxGxxBheb_ddfcUqij+A@mail.gmail.com>
In-Reply-To: <pull.2256.v2.git.1792135548923.gitgitgadget@gmail.com>

Show 10 quoted lines

> +       test_path_is_file .git/rr-cache/$rerere_id/postimage &&
>         git checkout -m fi/le &&
>         echo resurrect the conflict &&
>         test_grep "^=======" fi/le &&
> @@ -182,7 +182,7 @@ test_expect_success 'rerere and rerere forget' '
>         check_resolve_undo kept fi/le initial:fi/le second:fi/le third:fi/le &&
>         test -z "$(git ls-files -u)" &&
>         git rerere forget fi/le &&
> -       ! test -f .git/rr-cache/$rerere_id/postimage &&
> +       test_path_is_missing .git/rr-cache/$rerere_id/postimage &&

Seems like a good change, but there are lots of these calls in the codebase. Maybe change the others ones too, while you're at it?

Harald