git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] cache.h: remove always unused show_date_human() declaration

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 2, 2022, 21:03 UTC
Message-ID
<patch-1.5-fb21bd7b2c5-20220202T195651Z-avarab@gmail.com>
In-Reply-To
<cover-0.5-00000000000-20220202T195651Z-avarab@gmail.com>

There has never been a show_date_human() function on the "master" branch in git.git. This declaration was added in b841d4ff438 (Add `human` format to test-tool, 2019-01-28).

A look at the ML history reveals that it was leftover cruft from an earlier version of that commit[1].

1. https://lore.kernel.org/git/20190118061805.19086-5-ischis2@cox.net/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 cache.h | 2 --
 1 file changed, 2 deletions(-)
diff --git a/cache.h b/cache.h
index 281f00ab1b1..49b46244c74 100644
--- a/cache.h
+++ b/cache.h
@@ -1586,8 +1586,6 @@ struct date_mode *date_mode_from_type(enum date_mode_type type);
 
 const char *show_date(timestamp_t time, int timezone, const struct date_mode *mode);
 void show_date_relative(timestamp_t time, struct strbuf *timebuf);
-void show_date_human(timestamp_t time, int tz, const struct timeval *now,
-			struct strbuf *timebuf);
 int parse_date(const char *date, struct strbuf *out);
 int parse_date_basic(const char *date, timestamp_t *timestamp, int *offset);
 int parse_expiry_date(const char *date, timestamp_t *timestamp);
-- 
2.35.0.913.g12b4baa2536
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 93 of 125 in “UNLEAK(), leak checking in the default tests etc.”
  1. Ævar Arnfjörð BjarmasonJun 9, 2021
  2. Andrzej HuntJun 9, 2021
  3. Felipe ContrerasJun 9, 2021
  4. Jeff KingJun 10, 2021
  5. Ævar Arnfjörð BjarmasonJun 10, 2021
  6. Jeff KingJun 10, 2021
  7. Andrzej HuntJun 10, 2021
  8. Jeff KingJun 10, 2021
  9. Andrzej HuntJun 11, 2021
  10. SZEDER GáborJun 10, 2021
  11. 0/4 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  12. 1/4 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  13. Đoàn Trần Công DanhJul 14, 2021
  14. 2/4 SANITIZE tests: fix memory leaks in t13*config*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  15. 3/4 SANITIZE tests: fix memory leaks in t5701*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  16. 4/4 SANITIZE tests: fix leak in mailmap.cÆvar Arnfjörð Bjarmason, Jul 14, 2021
  17. Eric SunshineJul 14, 2021
  18. 0/4 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  19. 1/4 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  20. Andrzej HuntJul 14, 2021
  21. Ævar Arnfjörð BjarmasonJul 14, 2021
  22. Jeff KingJul 15, 2021
  23. Jeff KingJul 15, 2021
  24. Ævar Arnfjörð BjarmasonJul 16, 2021
  25. Jeff KingJul 16, 2021
  26. Jeff KingJul 16, 2021
  27. Ævar Arnfjörð BjarmasonJul 16, 2021
  28. Jeff KingJul 16, 2021
  29. 2/4 SANITIZE tests: fix memory leaks in t13*config*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  30. Andrzej HuntJul 14, 2021
  31. Ævar Arnfjörð BjarmasonJul 14, 2021
  32. Jeff KingJul 15, 2021
  33. Andrzej HuntJul 16, 2021
  34. Jeff KingJul 16, 2021
  35. Ævar Arnfjörð BjarmasonJul 16, 2021
  36. Jeff KingJul 16, 2021
  37. Ævar Arnfjörð BjarmasonAug 31, 2021
  38. Jeff KingSep 1, 2021
  39. Ævar Arnfjörð BjarmasonSep 1, 2021
  40. 3/4 SANITIZE tests: fix memory leaks in t5701*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  41. Andrzej HuntJul 15, 2021
  42. Jeff KingJul 15, 2021
  43. protocol-caps.c: fix memory leak in send_info()Ævar Arnfjörð Bjarmason, Aug 31, 2021
  44. Bruno AlbuquerqueAug 31, 2021
  45. Junio C HamanoAug 31, 2021
  46. 4/4 SANITIZE tests: fix leak in mailmap.cÆvar Arnfjörð Bjarmason, Jul 14, 2021
  47. mailmap.c: fix a memory leak in free_mailap_{info,entry}()Ævar Arnfjörð Bjarmason, Aug 31, 2021
  48. Eric SunshineAug 31, 2021
  49. Jeff KingAug 31, 2021
  50. Junio C HamanoAug 31, 2021
  51. Andrzej HuntJul 15, 2021
  52. 0/8 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Aug 31, 2021
  53. Jeff KingSep 1, 2021
  54. Jeff KingSep 1, 2021
  55. Ævar Arnfjörð BjarmasonSep 2, 2021
  56. Jeff KingSep 3, 2021
  57. 0/3 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  58. 1/3 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 7, 2021
  59. 2/3 CI: refactor "if" to "case" statementÆvar Arnfjörð Bjarmason, Sep 7, 2021
  60. 3/3 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  61. Eric SunshineSep 7, 2021
  62. Jeff KingSep 7, 2021
  63. Jeff KingSep 7, 2021
  64. Junio C HamanoSep 7, 2021
  65. 0/3 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  66. 1/3 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 7, 2021
  67. 2/3 CI: refactor "if" to "case" statementÆvar Arnfjörð Bjarmason, Sep 7, 2021
  68. 3/3 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  69. Eric SunshineSep 8, 2021
  70. fixup! tests: add a test mode for SANITIZE=leak, run it in CICarlo Marcelo Arenas Belón, Sep 16, 2021
  71. Ævar Arnfjörð BjarmasonSep 16, 2021
  72. Junio C HamanoSep 8, 2021
  73. Ævar Arnfjörð BjarmasonSep 8, 2021
  74. Emily ShafferSep 9, 2021
  75. 0/2 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 16, 2021
  76. 1/2 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 16, 2021
  77. 2/2 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 16, 2021
  78. 0/2 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 19, 2021
  79. 2/2 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 19, 2021
  80. fixup! tests: add a test mode for SANITIZE=leak, run it in CICarlo Marcelo Arenas Belón, Sep 22, 2021
  81. Ævar Arnfjörð BjarmasonSep 23, 2021
  82. 1/2 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 19, 2021
  83. 0/2 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 23, 2021
  84. 1/2 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 23, 2021
  85. 2/2 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 23, 2021
  86. Re* [PATCH v8 2/2] tests: add a test mode for SANITIZE=leak, run it in CIJunio C Hamano, Nov 3, 2021
  87. Junio C HamanoNov 3, 2021
  88. Ævar Arnfjörð BjarmasonNov 4, 2021
  89. t0006: date_mode can leak .strftime_fmt memberÆvar Arnfjörð Bjarmason, Nov 16, 2021
  90. Junio C HamanoNov 16, 2021
  91. Jeff KingNov 16, 2021
  92. 0/5 date.[ch] API: split from cache.h, add API docs, stop leaking memoryÆvar Arnfjörð Bjarmason, Feb 2, 2022
  93. 1/5 cache.h: remove always unused show_date_human() declarationÆvar Arnfjörð Bjarmason, Feb 2, 2022
  94. 2/5 date API: create a date.h, split from cache.hÆvar Arnfjörð Bjarmason, Feb 2, 2022
  95. Ævar Arnfjörð BjarmasonFeb 2, 2022
  96. Junio C HamanoFeb 15, 2022
  97. 3/5 date API: provide and use a DATE_MODE_INITÆvar Arnfjörð Bjarmason, Feb 2, 2022
  98. 4/5 date API: add basic API docsÆvar Arnfjörð Bjarmason, Feb 2, 2022
  99. Junio C HamanoFeb 15, 2022
  100. 5/5 date API: add and use a date_mode_release()Ævar Arnfjörð Bjarmason, Feb 2, 2022
  101. Junio C HamanoFeb 15, 2022
  102. 0/5 date.[ch] API: split from cache.h, add API docs, stop leaking memoryÆvar Arnfjörð Bjarmason, Feb 4, 2022
  103. 1/5 cache.h: remove always unused show_date_human() declarationÆvar Arnfjörð Bjarmason, Feb 4, 2022
  104. 2/5 date API: create a date.h, split from cache.hÆvar Arnfjörð Bjarmason, Feb 4, 2022
  105. 3/5 date API: provide and use a DATE_MODE_INITÆvar Arnfjörð Bjarmason, Feb 4, 2022
  106. 4/5 date API: add basic API docsÆvar Arnfjörð Bjarmason, Feb 4, 2022
  107. 5/5 date API: add and use a date_mode_release()Ævar Arnfjörð Bjarmason, Feb 4, 2022
  108. Ævar Arnfjörð BjarmasonFeb 14, 2022
  109. Junio C HamanoFeb 14, 2022
  110. 0/5 date.[ch] API: split from cache.h, add API docs, stop leaking memoryÆvar Arnfjörð Bjarmason, Feb 16, 2022
  111. 1/5 cache.h: remove always unused show_date_human() declarationÆvar Arnfjörð Bjarmason, Feb 16, 2022
  112. 2/5 date API: create a date.h, split from cache.hÆvar Arnfjörð Bjarmason, Feb 16, 2022
  113. 3/5 date API: provide and use a DATE_MODE_INITÆvar Arnfjörð Bjarmason, Feb 16, 2022
  114. 4/5 date API: add basic API docsÆvar Arnfjörð Bjarmason, Feb 16, 2022
  115. 5/5 date API: add and use a date_mode_release()Ævar Arnfjörð Bjarmason, Feb 16, 2022
  116. Junio C HamanoFeb 16, 2022
  117. 1/8 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Aug 31, 2021
  118. 2/8 CI: refactor "if" to "case" statementÆvar Arnfjörð Bjarmason, Aug 31, 2021
  119. 3/8 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Aug 31, 2021
  120. 4/8 tests: annotate t000*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  121. 5/8 tests: annotate t001*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  122. 6/8 tests: annotate t002*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  123. 7/8 tests: annotate select t0*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  124. 8/8 tests: annotate select t*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  125. Ævar Arnfjörð BjarmasonAug 31, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.