Re: UNLEAK(), leak checking in the default tests etc.

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 9, 2021, 20:36 UTC
Message-ID: <60c126456351d_aab462081@natae.notmuch>
In-Reply-To: <fcb0eaee-6ae1-f2cc-51d5-103eea64532a@ahunt.org>

Andrzej Hunt wrote:

> On 09/06/2021 16:38, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> > I wonder if that shouldn't be in DEVOPTS (or even a default under
> > DEVELOPER=1). I.e. you don't need any other special compile flags, just
> > a compiled git that you then run under valgrind to spot this.
> 
> I'm not familiar with git's development conventions/philosophy, but my 
> 2c is that it's better not to enable it by default in order to minimise 
> divergence from the code that users are running.

It woudln't be on by default, you would need to turn it on with `make DEVEOPER=1`.

-- 
Felipe Contreras

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.