git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] tests: add a test mode for SANITIZE=leak, run it in CI

From
Andrzej Hunt <andrzej@ahunt.org>
Date
Jul 14, 2021, 18:42 UTC
Message-ID
<eebb4f74-b5e3-6c11-3b84-fcee1b876992@ahunt.org>
In-Reply-To
<patch-1.4-0795436a24-20210714T172251Z-avarab@gmail.com>
On 14/07/2021 19:23, Ævar Arnfjörð Bjarmason wrote:
Show 67 quoted lines
> While git can be compiled with SANITIZE=leak there has been no
> corresponding GIT_TEST_* mode for it, i.e. memory leaks have been
> fixed as one-offs without structured regression testing.
> 
> This change add such a mode, we now have new
> linux-{clang,gcc}-sanitize-leak CI targets, these targets run the same
> tests as linux-{clang,gcc}, except that almost all of them are
> skipped.
> 
> There is a whitelist of some tests that are OK in test-lib.sh, and
> individual tests can be opted-in by setting
> GIT_TEST_SANITIZE_LEAK=true before sourcing test-lib.sh. Within those
> individual test can be skipped with the "!SANITIZE_LEAK"
> prerequisite. See the updated t/README for more details.
> 
> I'm using the GIT_TEST_SANITIZE_LEAK=true and !SANITIZE_LEAK pattern
> in a couple of tests whose memory leaks I'll fix in subsequent
> commits.
> 
> I'm not being aggressive about opting in tests, it's not all tests
> that currently pass under SANITIZE=leak, just a small number of
> known-good tests. We can add more later as we fix leaks and grow more
> confident in this test mode.
> 
> See the recent discussion at [1] about the lack of this sort of test
> mode, and 0e5bba53af (add UNLEAK annotation for reducing leak false
> positives, 2017-09-08) for the initial addition of SANITIZE=leak.
> 
> See also 09595ab381 (Merge branch 'jk/leak-checkers', 2017-09-19),
> 7782066f67 (Merge branch 'jk/apache-lsan', 2019-05-19) and the recent
> 936e58851a (Merge branch 'ah/plugleaks', 2021-05-07) for some of the
> past history of "one-off" SANITIZE=leak (and more) fixes.
> 
> When calling maybe_skip_all_sanitize_leak matching against
> "$TEST_NAME" instead of "$this_test" as other "match_pattern_list()"
> users do is intentional. I'd like to match things like "t13*config*"
> in subsequent commits. This part of the API isn't public, so we can
> freely change it in the future.
> 
> 1. https://lore.kernel.org/git/87czsv2idy.fsf@evledraar.gmail.com/
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>   .github/workflows/main.yml |  6 ++++
>   Makefile                   |  5 ++++
>   ci/install-dependencies.sh |  4 +--
>   ci/lib.sh                  | 18 ++++++++----
>   ci/run-build-and-tests.sh  |  4 +--
>   t/README                   | 16 ++++++++++
>   t/t5701-git-serve.sh       |  2 +-
>   t/test-lib.sh              | 60 ++++++++++++++++++++++++++++++++++++++
>   8 files changed, 105 insertions(+), 10 deletions(-)
> 
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 73856bafc9..752fe187f9 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -297,6 +297,12 @@ jobs:
>             - jobname: linux-gcc-default
>               cc: gcc
>               pool: ubuntu-latest
> +          - jobname: linux-clang-sanitize-leak
> +            cc: clang
> +            pool: ubuntu-latest
> +          - jobname: linux-gcc-sanitize-leak
> +            cc: gcc
> +            pool: ubuntu-latest

Is there any advantage to running leak checking with both gcc and clang? My understanding is that you end up using the same sanitiser implementation under the hood - I can't remember if using a different compiler actually helps find different leaks though.

My other question is: if we are adding a new job - should it really be just a leak checking job? Leak checking is just a subset of ASAN (Address Sanitizer). And as discussed at [1] it's possible to run ASAN and UBSAN (Undefined Behaviour Sanitizer) in the same build. I feel like it's much more useful to first add a combined ASAN+UBSAN job, followed by enabling leak-checking as part of ASAN in those jobs for known leak-free tests - as opposed to only adding leak checking. We currently disable Leak checking for ASAN here [2], but that could be made conditional on the test ID (i.e. check an allowlist to enable leak checking for some tests)?

I think it's worth focusing on ASAN+UBSAN first because they tend to 
find more impactful issues (e.g. buffer overflows, and other real bugs) 
- whereas leaks... are ugly, but leaks in git don't actually have much 
user impact?

[1] https://lore.kernel.org/git/YMI%2Fg1sHxJgb8%2FYD@coredump.intra.peff.net/

[2] https://git.kernel.org/pub/scm/git/git.git/tree/t/test-lib.sh#n44
Show 42 quoted lines
>       env:
>         CC: ${{matrix.vector.cc}}
>         jobname: ${{matrix.vector.jobname}}
> diff --git a/Makefile b/Makefile
> index 502e0c9a81..d4cad5136f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1216,6 +1216,9 @@ PTHREAD_CFLAGS =
>   SPARSE_FLAGS ?=
>   SP_EXTRA_FLAGS = -Wno-universal-initializer
>   
> +# For informing GIT-BUILD-OPTIONS of the SANITIZE=leak target
> +SANITIZE_LEAK =
> +
>   # For the 'coccicheck' target; setting SPATCH_BATCH_SIZE higher will
>   # usually result in less CPU usage at the cost of higher peak memory.
>   # Setting it to 0 will feed all files in a single spatch invocation.
> @@ -1260,6 +1263,7 @@ BASIC_CFLAGS += -DSHA1DC_FORCE_ALIGNED_ACCESS
>   endif
>   ifneq ($(filter leak,$(SANITIZERS)),)
>   BASIC_CFLAGS += -DSUPPRESS_ANNOTATED_LEAKS
> +SANITIZE_LEAK = YesCompiledWithIt >   endif
>   ifneq ($(filter address,$(SANITIZERS)),)
>   NO_REGEX = NeededForASAN
> @@ -2793,6 +2797,7 @@ GIT-BUILD-OPTIONS: FORCE
>   	@echo NO_UNIX_SOCKETS=\''$(subst ','\'',$(subst ','\'',$(NO_UNIX_SOCKETS)))'\' >>$@+
>   	@echo PAGER_ENV=\''$(subst ','\'',$(subst ','\'',$(PAGER_ENV)))'\' >>$@+
>   	@echo DC_SHA1=\''$(subst ','\'',$(subst ','\'',$(DC_SHA1)))'\' >>$@+
> +	@echo SANITIZE_LEAK=\''$(subst ','\'',$(subst ','\'',$(SANITIZE_LEAK)))'\' >>$@+
>   	@echo X=\'$(X)\' >>$@+
>   ifdef TEST_OUTPUT_DIRECTORY
>   	@echo TEST_OUTPUT_DIRECTORY=\''$(subst ','\'',$(subst ','\'',$(TEST_OUTPUT_DIRECTORY)))'\' >>$@+
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 67852d0d37..8ac72d7246 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -12,13 +12,13 @@ UBUNTU_COMMON_PKGS="make libssl-dev libcurl4-openssl-dev libexpat-dev
>    libemail-valid-perl libio-socket-ssl-perl libnet-smtp-ssl-perl"
>   
>   case "$jobname" in
> -linux-clang|linux-gcc)
> +linux-clang|linux-gcc|linux-clang-sanitize-leak|linux-gcc-sanitize-leak)
How about `linux-clang*|linux-gcc*)` here and below?
Show 46 quoted lines
>   	sudo apt-add-repository -y "ppa:ubuntu-toolchain-r/test"
>   	sudo apt-get -q update
>   	sudo apt-get -q -y install language-pack-is libsvn-perl apache2 \
>   		$UBUNTU_COMMON_PKGS
>   	case "$jobname" in
> -	linux-gcc)
> +	linux-gcc|linux-gcc-sanitize-leak)
>   		sudo apt-get -q -y install gcc-8
>   		;;
>   	esac
> diff --git a/ci/lib.sh b/ci/lib.sh
> index 476c3f369f..bb02b5abf4 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -183,14 +183,16 @@ export GIT_TEST_CLONE_2GB=true
>   export SKIP_DASHED_BUILT_INS=YesPlease
>   
>   case "$jobname" in
> -linux-clang|linux-gcc)
> -	if [ "$jobname" = linux-gcc ]
> -	then
> +linux-clang|linux-gcc|linux-clang-sanitize-leak|linux-gcc-sanitize-leak)
> +	case "$jobname" in
> +	linux-gcc|linux-gcc-sanitize-leak)
>   		export CC=gcc-8
>   		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/python3"
> -	else
> +		;;
> +	*)
>   		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/python2"
> -	fi
> +		;;
> +	esac
>   
>   	export GIT_TEST_HTTPD=true
>   
> @@ -233,4 +235,10 @@ linux-musl)
>   	;;
>   esac
>   
> +case "$jobname" in
> +linux-clang-sanitize-leak|linux-gcc-sanitize-leak)
> +	export SANITIZE=leak
> +	;;
> +esac
> +

Have you considered doing this in the yaml job configuration instead? It's possible to set env-vars in yaml, although it will require some careful tweaking - here's an example where I'm setting different values for SANITIZE depending on job (you'd probably just have to set it to empty for the non leak-checking jobs):

https://github.com/ahunt/git/blob/master/.github/workflows/ahunt-sync-next2.yml#L51-L69

That does make the yaml more complex, but I think it's worth it to reduce the amount of special-casing elsewhere (and is also worth it if we ever add other sanitisers)?

Show 149 quoted lines
>   MAKEFLAGS="$MAKEFLAGS CC=${CC:-cc}"
> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
> index 3ce81ffee9..5fe047b5c6 100755
> --- a/ci/run-build-and-tests.sh
> +++ b/ci/run-build-and-tests.sh
> @@ -12,7 +12,7 @@ esac
>   
>   make
>   case "$jobname" in
> -linux-gcc)
> +linux-gcc|linux-gcc-sanitize-leak)
>   	export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
>   	make test
>   	export GIT_TEST_SPLIT_INDEX=yes
> @@ -29,7 +29,7 @@ linux-gcc)
>   	export GIT_TEST_CHECKOUT_WORKERS=2
>   	make test
>   	;;
> -linux-clang)
> +linux-clang|linux-clang-sanitize-leak)
>   	export GIT_TEST_DEFAULT_HASH=sha1
>   	make test
>   	export GIT_TEST_DEFAULT_HASH=sha256
> diff --git a/t/README b/t/README
> index 1a2072b2c8..303d0be817 100644
> --- a/t/README
> +++ b/t/README
> @@ -448,6 +448,22 @@ GIT_TEST_CHECKOUT_WORKERS=<n> overrides the 'checkout.workers' setting
>   to <n> and 'checkout.thresholdForParallelism' to 0, forcing the
>   execution of the parallel-checkout code.
>   
> +GIT_TEST_SANITIZE_LEAK=<boolean> will force the tests to run when git
> +is compiled with SANITIZE=leak (we pick it up via
> +../GIT-BUILD-OPTIONS).
> +
> +By default all tests are skipped when compiled with SANITIZE=leak, and
> +individual test scripts opt themselves in to leak testing by setting
> +GIT_TEST_SANITIZE_LEAK=true before sourcing test-lib.sh. Within those
> +tests use the SANITIZE_LEAK prerequisite to skip individiual tests
> +(i.e. test_expect_success !SANITIZE_LEAK [...]).
> +
> +So the GIT_TEST_SANITIZE_LEAK setting is different in behavior from
> +both other GIT_TEST_*=[true|false] settings, but more useful given how
> +SANITIZE=leak works & the state of the test suite. Manually setting
> +GIT_TEST_SANITIZE_LEAK=true is only useful during development when
> +finding and fixing memory leaks.
> +
>   Naming Tests
>   ------------
>   
> diff --git a/t/t5701-git-serve.sh b/t/t5701-git-serve.sh
> index 930721f053..d58efb0aa9 100755
> --- a/t/t5701-git-serve.sh
> +++ b/t/t5701-git-serve.sh
> @@ -243,7 +243,7 @@ test_expect_success 'unexpected lines are not allowed in fetch request' '
>   
>   # Test the basics of object-info
>   #
> -test_expect_success 'basics of object-info' '
> +test_expect_success !SANITIZE_LEAK 'basics of object-info' '
>   	test-tool pkt-line pack >in <<-EOF &&
>   	command=object-info
>   	object-format=$(test_oid algo)
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 7036f83b33..9201510e16 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1353,6 +1353,40 @@ then
>   	exit 1
>   fi
>   
> +# SANITIZE=leak test mode
> +sanitize_leak_true=
> +add_sanitize_leak_true () {
> +	sanitize_leak_true="$sanitize_leak_true$1 "
> +}
> +
> +sanitize_leak_false=
> +add_sanitize_leak_false () {
> +	sanitize_leak_false="$sanitize_leak_false$1 "
> +}
> +
> +sanitize_leak_opt_in_msg="opt-in with GIT_TEST_SANITIZE_LEAK=true"
> +maybe_skip_all_sanitize_leak () {
> +	# Whitelist patterns
> +	add_sanitize_leak_true 't000*'
> +	add_sanitize_leak_true 't001*'
> +	add_sanitize_leak_true 't006*'
> +
> +	# Blacklist patterns (overrides whitelist)
> +	add_sanitize_leak_false 't000[469]*'
> +	add_sanitize_leak_false 't001[2459]*'
> +	add_sanitize_leak_false 't006[0248]*'
> +
> +	if match_pattern_list "$1" "$sanitize_leak_false"
> +	then
> +		skip_all="test $this_test on SANITIZE=leak blacklist, $sanitize_leak_opt_in_msg"
> +		test_done
> +	elif match_pattern_list "$1" "$sanitize_leak_true"
> +	then
> +		return 0
> +	fi
> +	return 1
> +}
> +
>   # Are we running this test at all?
>   remove_trash=
>   this_test=${0##*/}
> @@ -1364,6 +1398,31 @@ then
>   	test_done
>   fi
>   
> +# Aggressively skip non-whitelisted tests when compiled with
> +# SANITIZE=leak
> +if test -n "$SANITIZE_LEAK"
> +then
> +	if test -z "$GIT_TEST_SANITIZE_LEAK" &&
> +		maybe_skip_all_sanitize_leak "$TEST_NAME"
> +	then
> +		say_color info >&3 "test $this_test on SANITIZE=leak whitelist"
> +		GIT_TEST_SANITIZE_LEAK=true
> +	fi
> +
> +	# We need to see it in "git env--helper" (via
> +	# test_bool_env)
> +	export GIT_TEST_SANITIZE_LEAK
> +
> +	if ! test_bool_env GIT_TEST_SANITIZE_LEAK false
> +	then
> +		skip_all="skip all tests in $this_test under SANITIZE=leak, $sanitize_leak_opt_in_msg"
> +		test_done
> +	fi
> +elif test_bool_env GIT_TEST_SANITIZE_LEAK false
> +then
> +	error "GIT_TEST_SANITIZE_LEAK=true has no effect except when compiled with SANITIZE=leak"
> +fi
> +
>   # Last-minute variable setup
>   HOME="$TRASH_DIRECTORY"
>   GNUPGHOME="$HOME/gnupg-home-not-used"
> @@ -1516,6 +1575,7 @@ test -z "$NO_PYTHON" && test_set_prereq PYTHON
>   test -n "$USE_LIBPCRE2" && test_set_prereq PCRE
>   test -n "$USE_LIBPCRE2" && test_set_prereq LIBPCRE2
>   test -z "$NO_GETTEXT" && test_set_prereq GETTEXT
> +test -n "$SANITIZE_LEAK" && test_set_prereq SANITIZE_LEAK
>   
>   if test -z "$GIT_TEST_CHECK_CACHE_TREE"
>   then
>
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 20 of 125 in “UNLEAK(), leak checking in the default tests etc.”
  1. Ævar Arnfjörð BjarmasonJun 9, 2021
  2. Andrzej HuntJun 9, 2021
  3. Felipe ContrerasJun 9, 2021
  4. Jeff KingJun 10, 2021
  5. Ævar Arnfjörð BjarmasonJun 10, 2021
  6. Jeff KingJun 10, 2021
  7. Andrzej HuntJun 10, 2021
  8. Jeff KingJun 10, 2021
  9. Andrzej HuntJun 11, 2021
  10. SZEDER GáborJun 10, 2021
  11. 0/4 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  12. 1/4 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  13. Đoàn Trần Công DanhJul 14, 2021
  14. 2/4 SANITIZE tests: fix memory leaks in t13*config*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  15. 3/4 SANITIZE tests: fix memory leaks in t5701*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  16. 4/4 SANITIZE tests: fix leak in mailmap.cÆvar Arnfjörð Bjarmason, Jul 14, 2021
  17. Eric SunshineJul 14, 2021
  18. 0/4 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  19. 1/4 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Jul 14, 2021
  20. Andrzej HuntJul 14, 2021
  21. Ævar Arnfjörð BjarmasonJul 14, 2021
  22. Jeff KingJul 15, 2021
  23. Jeff KingJul 15, 2021
  24. Ævar Arnfjörð BjarmasonJul 16, 2021
  25. Jeff KingJul 16, 2021
  26. Jeff KingJul 16, 2021
  27. Ævar Arnfjörð BjarmasonJul 16, 2021
  28. Jeff KingJul 16, 2021
  29. 2/4 SANITIZE tests: fix memory leaks in t13*config*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  30. Andrzej HuntJul 14, 2021
  31. Ævar Arnfjörð BjarmasonJul 14, 2021
  32. Jeff KingJul 15, 2021
  33. Andrzej HuntJul 16, 2021
  34. Jeff KingJul 16, 2021
  35. Ævar Arnfjörð BjarmasonJul 16, 2021
  36. Jeff KingJul 16, 2021
  37. Ævar Arnfjörð BjarmasonAug 31, 2021
  38. Jeff KingSep 1, 2021
  39. Ævar Arnfjörð BjarmasonSep 1, 2021
  40. 3/4 SANITIZE tests: fix memory leaks in t5701*, add to whitelistÆvar Arnfjörð Bjarmason, Jul 14, 2021
  41. Andrzej HuntJul 15, 2021
  42. Jeff KingJul 15, 2021
  43. protocol-caps.c: fix memory leak in send_info()Ævar Arnfjörð Bjarmason, Aug 31, 2021
  44. Bruno AlbuquerqueAug 31, 2021
  45. Junio C HamanoAug 31, 2021
  46. 4/4 SANITIZE tests: fix leak in mailmap.cÆvar Arnfjörð Bjarmason, Jul 14, 2021
  47. mailmap.c: fix a memory leak in free_mailap_{info,entry}()Ævar Arnfjörð Bjarmason, Aug 31, 2021
  48. Eric SunshineAug 31, 2021
  49. Jeff KingAug 31, 2021
  50. Junio C HamanoAug 31, 2021
  51. Andrzej HuntJul 15, 2021
  52. 0/8 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Aug 31, 2021
  53. Jeff KingSep 1, 2021
  54. Jeff KingSep 1, 2021
  55. Ævar Arnfjörð BjarmasonSep 2, 2021
  56. Jeff KingSep 3, 2021
  57. 0/3 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  58. 1/3 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 7, 2021
  59. 2/3 CI: refactor "if" to "case" statementÆvar Arnfjörð Bjarmason, Sep 7, 2021
  60. 3/3 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  61. Eric SunshineSep 7, 2021
  62. Jeff KingSep 7, 2021
  63. Jeff KingSep 7, 2021
  64. Junio C HamanoSep 7, 2021
  65. 0/3 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  66. 1/3 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 7, 2021
  67. 2/3 CI: refactor "if" to "case" statementÆvar Arnfjörð Bjarmason, Sep 7, 2021
  68. 3/3 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 7, 2021
  69. Eric SunshineSep 8, 2021
  70. fixup! tests: add a test mode for SANITIZE=leak, run it in CICarlo Marcelo Arenas Belón, Sep 16, 2021
  71. Ævar Arnfjörð BjarmasonSep 16, 2021
  72. Junio C HamanoSep 8, 2021
  73. Ævar Arnfjörð BjarmasonSep 8, 2021
  74. Emily ShafferSep 9, 2021
  75. 0/2 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 16, 2021
  76. 1/2 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 16, 2021
  77. 2/2 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 16, 2021
  78. 0/2 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 19, 2021
  79. 2/2 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 19, 2021
  80. fixup! tests: add a test mode for SANITIZE=leak, run it in CICarlo Marcelo Arenas Belón, Sep 22, 2021
  81. Ævar Arnfjörð BjarmasonSep 23, 2021
  82. 1/2 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 19, 2021
  83. 0/2 add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 23, 2021
  84. 1/2 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Sep 23, 2021
  85. 2/2 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Sep 23, 2021
  86. Re* [PATCH v8 2/2] tests: add a test mode for SANITIZE=leak, run it in CIJunio C Hamano, Nov 3, 2021
  87. Junio C HamanoNov 3, 2021
  88. Ævar Arnfjörð BjarmasonNov 4, 2021
  89. t0006: date_mode can leak .strftime_fmt memberÆvar Arnfjörð Bjarmason, Nov 16, 2021
  90. Junio C HamanoNov 16, 2021
  91. Jeff KingNov 16, 2021
  92. 0/5 date.[ch] API: split from cache.h, add API docs, stop leaking memoryÆvar Arnfjörð Bjarmason, Feb 2, 2022
  93. 1/5 cache.h: remove always unused show_date_human() declarationÆvar Arnfjörð Bjarmason, Feb 2, 2022
  94. 2/5 date API: create a date.h, split from cache.hÆvar Arnfjörð Bjarmason, Feb 2, 2022
  95. Ævar Arnfjörð BjarmasonFeb 2, 2022
  96. Junio C HamanoFeb 15, 2022
  97. 3/5 date API: provide and use a DATE_MODE_INITÆvar Arnfjörð Bjarmason, Feb 2, 2022
  98. 4/5 date API: add basic API docsÆvar Arnfjörð Bjarmason, Feb 2, 2022
  99. Junio C HamanoFeb 15, 2022
  100. 5/5 date API: add and use a date_mode_release()Ævar Arnfjörð Bjarmason, Feb 2, 2022
  101. Junio C HamanoFeb 15, 2022
  102. 0/5 date.[ch] API: split from cache.h, add API docs, stop leaking memoryÆvar Arnfjörð Bjarmason, Feb 4, 2022
  103. 1/5 cache.h: remove always unused show_date_human() declarationÆvar Arnfjörð Bjarmason, Feb 4, 2022
  104. 2/5 date API: create a date.h, split from cache.hÆvar Arnfjörð Bjarmason, Feb 4, 2022
  105. 3/5 date API: provide and use a DATE_MODE_INITÆvar Arnfjörð Bjarmason, Feb 4, 2022
  106. 4/5 date API: add basic API docsÆvar Arnfjörð Bjarmason, Feb 4, 2022
  107. 5/5 date API: add and use a date_mode_release()Ævar Arnfjörð Bjarmason, Feb 4, 2022
  108. Ævar Arnfjörð BjarmasonFeb 14, 2022
  109. Junio C HamanoFeb 14, 2022
  110. 0/5 date.[ch] API: split from cache.h, add API docs, stop leaking memoryÆvar Arnfjörð Bjarmason, Feb 16, 2022
  111. 1/5 cache.h: remove always unused show_date_human() declarationÆvar Arnfjörð Bjarmason, Feb 16, 2022
  112. 2/5 date API: create a date.h, split from cache.hÆvar Arnfjörð Bjarmason, Feb 16, 2022
  113. 3/5 date API: provide and use a DATE_MODE_INITÆvar Arnfjörð Bjarmason, Feb 16, 2022
  114. 4/5 date API: add basic API docsÆvar Arnfjörð Bjarmason, Feb 16, 2022
  115. 5/5 date API: add and use a date_mode_release()Ævar Arnfjörð Bjarmason, Feb 16, 2022
  116. Junio C HamanoFeb 16, 2022
  117. 1/8 Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Aug 31, 2021
  118. 2/8 CI: refactor "if" to "case" statementÆvar Arnfjörð Bjarmason, Aug 31, 2021
  119. 3/8 tests: add a test mode for SANITIZE=leak, run it in CIÆvar Arnfjörð Bjarmason, Aug 31, 2021
  120. 4/8 tests: annotate t000*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  121. 5/8 tests: annotate t001*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  122. 6/8 tests: annotate t002*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  123. 7/8 tests: annotate select t0*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  124. 8/8 tests: annotate select t*.sh with TEST_PASSES_SANITIZE_LEAK=trueÆvar Arnfjörð Bjarmason, Aug 31, 2021
  125. Ævar Arnfjörð BjarmasonAug 31, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.