Re: [PATCH 4/4] SANITIZE tests: fix leak in mailmap.c

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 14, 2021, 02:19 UTC
Message-ID: <CAPig+cTnRiZaHYw9LBVADoRY695D=ckRbyPzE1qG7o3qCsNeQQ@mail.gmail.com>
In-Reply-To: <patch-4.4-b8062a09f9-20210714T001007Z-avarab@gmail.com>

On Tue, Jul 13, 2021 at 8:12 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 9 quoted lines

> Get closer to being able to run t4203-mailmap.sh by fixing a couple of
> memory leak in mailmap.c.
>
> In the free_mailmap_entry() code added in 0925ce4d49 (Add map_user()
> and clear_mailmap() to mailmap, 2009-02-08) the intent was clearly to
> clear the "me" structure, but while we freed parts of the
> mailmap_entry structure, we didn't free the structure itself. The same
> goes for the "mailmap_info" structure.
> ---

Missing sign-off.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.