Re: [PATCH] protocol-caps.c: fix memory leak in send_info()

From: Bruno Albuquerque <bga@google.com>
Date: Aug 31, 2021, 15:32 UTC
Message-ID: <CAPeR6H6g_VM3SUyjfYfc+mQa27af7AJE9wbKN_TUdG6m5rAUow@mail.gmail.com>
In-Reply-To: <patch-1.1-9acbc21cdd3-20210831T134632Z-avarab@gmail.com>

On Tue, Aug 31, 2021 at 6:46 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

[Replying again as I used HTML mail by mistake. Sorry.]

Show 12 quoted lines

> Fix a memory leak in a2ba162cda (object-info: support for retrieving
> object info, 2021-04-20) which appears to have been based on a
> misunderstanding of how the pkt-line.c API works. There is no need to
> strdup() input to packet_writer_write(), it's just a printf()-like
> format function.
>
> This fixes a potentially large memory leak, since the number of OID
> lines the "object-info" call can be arbitrarily large (or a small one
> if the request is small).
>
> This makes t5701-git-serve.sh pass again under SANITIZE=leak, as it
> did before a2ba162cda2.

Thanks for cleaning up after me. Yes, this was my lack of knowledge on how the internals of Git works. I was also not aware of SANITIZE=leak so thanks for the heads up. This looks good to me.