Re: [PATCH 1/2] diff: Fix modified lines stats with --stat and --numstat

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 23, 2020, 15:05 UTC
Message-ID: <nycvar.QRO.7.76.6.2009231702160.5061@tvgsbejvaqbjf.bet>
In-Reply-To: <20200918172747.GD183026@coredump.intra.peff.net>

Hi Peff,

On Fri, 18 Sep 2020, Jeff King wrote:

> I also wonder whether range-diff ought to be using that flag
> [`oid_valid`] instead of is_stdin.

From `diffcore.h`:

        unsigned oid_valid : 1;  /* if true, use oid and trust mode;
                                  * if false, use the name and read from
                                  * the filesystem.
                                  */

That description leads me to believe that `oid_valid` cannot be used here: we do _not_ want to read any data from the file system in `range-diff.c`'s `get_filespec()` function; Instead, we want to use the data provided via the function parameter `p`.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.