Re: Allow passing pipes to diff --no-index + bugfix

From: Thomas Guyot-Sionnest <tguyot@gmail.com>
Date: Sep 18, 2020, 18:24 UTC
Message-ID: <CALqVohdQwPppBsdsJjUhpXGZsZ=XCY_he7oFj1He1T8PjRLULw@mail.gmail.com>
In-Reply-To: <xmqq7dsrm0r8.fsf@gitster.c.googlers.com>

On Fri, 18 Sep 2020 at 13:51, Junio C Hamano <gitster@pobox.com> wrote:

>
> Next time, please send each of such unrelated patches independently,
> not as a two-patch series that gives a (false) impression that the
> second one needs the first one to work correctly.

Hi Junio,

My apologies for not making it clear enough - the fix in the first patch is for an edgy case of git diff-range, but the same fix applies to the 2nd patch. Any diff --stat comparison of two pipes would return 0-line diffs although the files would be marked as changed.

It was originally just one commit; I splitted it up when I realized a test was actually triggered by this fix (false negative without the fix, false positive with it) as it's still independent enough to be reviewed/merged alone.

Regards,

Thomas