Re: [PATCH 2/2] Allow passing pipes for input pipes to diff --no-index

From: Jeff King <peff@peff.net>
Date: Sep 18, 2020, 17:20 UTC
Message-ID: <20200918172044.GB183026@coredump.intra.peff.net>
In-Reply-To: <20200918143647.GB1606445@nand.local>

On Fri, Sep 18, 2020 at 10:36:47AM -0400, Taylor Blau wrote:

>   - The cat pipe is unnecessary, and is also violating a rule that we
>     don't place 'git' on the right-hand side of a pipe (can you redirect
>     the file at the end instead?).

What's wrong with git on the right-hand side of a pipe?

On the left-hand side we lose its exit code, which is bad. But on the right hand side, we are only losing the exit code of "cat", which we don't care about.

(Though I agree that "cat" is pointless here; we could just be redirecting from a file).

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.