From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 23 Sep 2020 15:05:16 GMT
Subject: Re: [PATCH 1/2] diff: Fix modified lines stats with --stat and --numstat
Message-ID: <nycvar.QRO.7.76.6.2009231702160.5061@tvgsbejvaqbjf.bet>
In-Reply-To: <20200918172747.GD183026@coredump.intra.peff.net>

Hi Peff,

On Fri, 18 Sep 2020, Jeff King wrote:

> I also wonder whether range-diff ought to be using that flag
> [`oid_valid`] instead of is_stdin.

From `diffcore.h`:

        unsigned oid_valid : 1;  /* if true, use oid and trust mode;
                                  * if false, use the name and read from
                                  * the filesystem.
                                  */

That description leads me to believe that `oid_valid` cannot be used here:
we do _not_ want to read any data from the file system in `range-diff.c`'s
`get_filespec()` function; Instead, we want to use the data provided via
the function parameter `p`.

Ciao,
Dscho