Re: [GSoC][PATCH v4 2/2] rebase--interactive: rewrite append_todo_help() in C
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 26, 2018, 21:43 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1806262343050.21419@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20180626161643.31152-3-alban.gruin@gmail.com>
Hi Alban,
On Tue, 26 Jun 2018, Alban Gruin wrote:
Show 15 quoted lines
> This rewrites append_todo_help() from shell to C. It also incorporates > some parts of initiate_action() and complete_action() that also write > help texts to the todo file. > > This also introduces the source file rebase-interactive.c. This file > will contain functions necessary for interactive rebase that are too > specific for the sequencer, and is part of libgit.a. > > Two flags are added to rebase--helper.c: one to call > append_todo_help() (`--append-todo-help`), and another one to tell > append_todo_help() to write the help text suited for the edit-todo > mode (`--write-edit-todo`). > > Finally, append_todo_help() is removed from git-rebase--interactive.sh > to use `rebase--helper --append-todo-help` instead.
Looks good!
Thanks, Dscho